Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DasharoModulePkg: Add Fans Off feature #193

Merged
merged 2 commits into from
Dec 2, 2024
Merged

DasharoModulePkg: Add Fans Off feature #193

merged 2 commits into from
Dec 2, 2024

Conversation

miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented Nov 27, 2024

No description provided.

@miczyg1 miczyg1 marked this pull request as draft November 27, 2024 14:00
@miczyg1 miczyg1 marked this pull request as ready for review November 28, 2024 18:03
@miczyg1 miczyg1 requested a review from mkopec November 29, 2024 10:53
@miczyg1
Copy link
Contributor Author

miczyg1 commented Nov 29, 2024

@mkopec I wonder if we want to hide the Fan off option on laptops. Rather not useful there.

@mkopec
Copy link
Member

mkopec commented Nov 29, 2024

@miczyg1 I think we want to hide that option on laptops

@miczyg1
Copy link
Contributor Author

miczyg1 commented Nov 29, 2024

@miczyg1 I think we want to hide that option on laptops

Added in 0d915b8

@mkopec mkopec merged commit 0d915b8 into dasharo Dec 2, 2024
3 checks passed
@mkopec mkopec deleted the fan_off_feature branch December 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants