Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/test.yml: Improve test workflow #200

Merged
merged 49 commits into from
Dec 17, 2024

Conversation

EduKav1813
Copy link
Contributor

No description provided.

@EduKav1813 EduKav1813 self-assigned this Dec 3, 2024
@EduKav1813 EduKav1813 changed the title .github/workflows/test.yml: Move IPXE server to script in osfv .github/workflows/test.yml: Improve test workflow Dec 5, 2024
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change indentation to 4 spaces? we have 2 spaces everywhere else.

@EduKav1813
Copy link
Contributor Author

@m-iwanicki Changed to 2 spaces.

@EduKav1813 EduKav1813 requested a review from m-iwanicki December 5, 2024 13:44
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably rebase on develop as there were couple changes

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@EduKav1813 EduKav1813 requested a review from m-iwanicki December 6, 2024 11:14
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next batch

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@EduKav1813 EduKav1813 requested a review from m-iwanicki December 6, 2024 14:25
@EduKav1813 EduKav1813 changed the base branch from develop to main December 10, 2024 12:43
EduKav1813 and others added 17 commits December 12, 2024 10:34
Signed-off-by: Michał Iwanicki <[email protected]>
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optiplex and pcengines_dpp failures look like problems with tests not workflow so I guess only one change is needed.

.github/workflows/test.yml Show resolved Hide resolved
@EduKav1813
Copy link
Contributor Author

@m-iwanicki In the last commit I made cleanup of the temporary changes. Once we will have the results of the CI runs I think we can finally merge this.

@m-iwanicki
Copy link
Contributor

After run finishes MAKE SURE to change target branch to develop

Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, errors look like problems with tests not workflow itself. Change target branch before mergings

------------------------------------------------------------------------------
E2E003.005 MSI PRO Z690-A DDR-4 initial deployment (legacy -> Core... | FAIL |
No match found for 'iPXE Shell' in 30 seconds. Output:
------------------------------------------------------------------------------
E2E003.006 MSI PRO Z690-A initial deployment (legacy -> Coreboot +... | PASS |
------------------------------------------------------------------------------
E2E003.009 MSI PRO Z690-A DDR-4 update (Coreboot + UEFI -> Coreboo... | PASS |
------------------------------------------------------------------------------
E2E003.010 MSI PRO Z690-A update (Coreboot + UEFI -> Coreboot + UE... | FAIL |
No match found for 'Does it match your actual specification? (Y|n)' in 30 seconds. Output:

Gathering flash chip and chipset information...
Flash information: Test Flash Chip
Flash size: 2M
Waiting for network connection ...
Network connection have been established!
Checking if board is Dasharo compatible.
Getting platform specific GPG key... 2
Done
Waiting for system clock to be synced ...
  DPP version (coreboot + Heads) available but you don't have access
  to it, if you are interested, please visit
  https://shop.3mdeb.com/product-category/dasharo-pro-package/

Current Dasharo version: 1.0.0
Latest available Dasharo version for your subscribtion: 1.1.4
Checking Dasharo firmware checksum... Verified.
Checking Dasharo firmware
------------------------------------------------------------------------------
Dts-E2E                                                               | FAIL |

@EduKav1813 EduKav1813 changed the base branch from main to develop December 17, 2024 16:25
@EduKav1813 EduKav1813 merged commit eee732d into develop Dec 17, 2024
11 of 12 checks passed
@m-iwanicki m-iwanicki deleted the improve-meta-dts-test-workflow branch December 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants