Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dts scripts enhanced logging #219

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Dts scripts enhanced logging #219

merged 1 commit into from
Jan 10, 2025
+1 −1

Conversation

m-iwanicki
Copy link
Contributor

@m-iwanicki m-iwanicki commented Jan 10, 2025 •
edited
Loading

@DaniilKl started osfv test by setting target branch to main for a second. Let's wait for results as my PR made few changes.

@m-iwanicki m-iwanicki requested a review from DaniilKl January 10, 2025 11:43
@m-iwanicki m-iwanicki self-assigned this Jan 10, 2025
@m-iwanicki m-iwanicki changed the base branch from main to develop January 10, 2025 11:44
@DaniilKl
Copy link
Contributor

Looks good but lets wait for CIs.

@m-iwanicki
Copy link
Contributor Author

@DaniilKl

Network connection timeout issue, everything else works :)

==============================================================================
Dts-E2E
==============================================================================
E2E003.001 MSI PRO Z690-A DDR4 initial deployment (legacy -> Coreb... | PASS |
------------------------------------------------------------------------------
E2E003.002 MSI PRO Z690-A initial deployment (legacy -> Coreboot +... | PASS |
------------------------------------------------------------------------------
E2E003.007 MSI PRO Z690-A DDR-4 update (Coreboot + UEFI -> Coreboo... | PASS |
------------------------------------------------------------------------------
E2E003.008 MSI PRO Z690-A update (Coreboot + UEFI -> Coreboot + UE... | FAIL |
No match found for 'Does it match your actual specification? (Y|n)' in 30 seconds. Output:
2

Gathering flash chip and chipset information...
Flash information: Test Flash Chip
Flash size: 2M
Waiting for network connection ...
Network connection have been established!
Checking if board is Dasharo compatible.
Getting platform specific GPG key... Done
Waiting for system clock to be synced ...
  DPP version (coreboot + Heads) available but you don't have access
  to it, if you are interested, please visit
  https://shop.3mdeb.com/product-category/dasharo-pro-package/

  DPP version (coreboot + UEFI) available but you don't have access
  to it, if you are interested, please visit
  https://shop.3mdeb.com/product-category/dasharo-pro-package/

Current Dasharo version: 1.0.0
Latest available Dasharo version for your subscription: 1.1.1
------------------------------------------------------------------------------
Dts-E2E                                                               | FAIL |
4 tests, 3 passed, 1 failed
==============================================================================

@DaniilKl
Copy link
Contributor

Network connection timeout issue

From the logs you sent:

(...)
Network connection have been established!
(...)

It is not clear what happened.

@m-iwanicki
Copy link
Contributor Author

It most likely got stuck on download_bios. After that it would enter verify_artifacts and echo something.

@DaniilKl
Copy link
Contributor

I guess the downloading step failed, but it is not shown in the failed test logs. We definitely need to work on debugging the tests.

@m-iwanicki
Copy link
Contributor Author

Add post test step and check if test failed. If it did then copy logs somewhere or just use built in log sending and send them to cloud.

@m-iwanicki
dts-scripts: enhanced logging also fixes Dasharo/dasharo-issues#1165
f3815db 
Verbose (xtrace) logging is always enabled but isn't shown on screen,
logs (stdout/ERR_LOG_FILE/xtrace) have timestamp included to easier
connect logs from different files.

Signed-off-by: Michał Iwanicki <[email protected]>
@m-iwanicki m-iwanicki force-pushed the dts-scripts-enhanced-logging branch from 57fb76c to f3815db Compare January 10, 2025 15:10
@m-iwanicki m-iwanicki merged commit f3815db into develop Jan 10, 2025
1 check was pending
@DaniilKl DaniilKl mentioned this pull request Jan 10, 2025
Open
@m-iwanicki m-iwanicki deleted the dts-scripts-enhanced-logging branch January 10, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniilKl DaniilKl DaniilKl approved these changes

Assignees

@m-iwanicki m-iwanicki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-iwanicki @DaniilKl