Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG fix #225

Merged
merged 2 commits into from
Jan 17, 2025
Merged

CHANGELOG fix #225

merged 2 commits into from
Jan 17, 2025

Conversation

PLangowski
Copy link
Collaborator

No description provided.

@PLangowski PLangowski changed the title CHANGELOG.md: Fix change notes CHANGELOG fix Jan 17, 2025
@PLangowski PLangowski marked this pull request as draft January 17, 2025 10:03
@PLangowski PLangowski marked this pull request as ready for review January 17, 2025 10:32
@PLangowski PLangowski requested a review from m-iwanicki January 17, 2025 10:32
This was referenced Jan 17, 2025
Closed
Closed
m-iwanicki
m-iwanicki requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove []:

meta-dts/CHANGELOG.md

Line 831 in e860d6f

## [1.1.1] - 2023-02-17

Otherwise it looks ok

@m-iwanicki
Copy link
Contributor

@PLangowski and change target branch to develop not main.

m-iwanicki
m-iwanicki requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also remove this line (duplicate of previous one):

meta-dts/CHANGELOG.md

Line 285 in e860d6f

- Update meta-dts-distro/recipes-dts/dts/dasharo-deploy/dasharo-deploy

@PLangowski PLangowski changed the base branch from main to develop January 17, 2025 10:59
@PLangowski
Copy link
Collaborator Author

@m-iwanicki done https://github.com/Dasharo/meta-dts/compare/e860d6f24efcba6122aa1fa504254ba887d9f548..11c32f91f46a5c10ae9ddeb4941a27edc6ec7ded

@PLangowski PLangowski requested a review from m-iwanicki January 17, 2025 11:03
@PLangowski PLangowski force-pushed the changelog-fix branch 2 times, most recently from c3c40ab to a682f9f Compare January 17, 2025 11:11
@PLangowski
CHANGELOG.md: Fix change notes
f796ed1 
Signed-off-by: Pawel Langowski <[email protected]>
@PLangowski
Remove links from changelog
4c84bf6 
Signed-off-by: Pawel Langowski <[email protected]>
@PLangowski PLangowski merged commit 91c9f00 into develop Jan 17, 2025
1 check passed
@PLangowski PLangowski deleted the changelog-fix branch January 17, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-iwanicki m-iwanicki m-iwanicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PLangowski @m-iwanicki