Add delay for telemetry requests #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --- | ||
| features: | ||
| - | | ||
| Added a /test/settings endpoint to change the settings on the fly. |
There was a problem hiding this comment.
little bit iffy about exposing the raw config values direct to users. This'll probably result in accidental breakages to downstream test suites that depend on config values that we might accidentally change in the test agent.
If we do wanna go this route then I'll want to ensure we have tests covering the config names we want to be stable. Otherwise can we hold off on adding this endpoint for now?
Kyle-Verhoog
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
--trace-request-delayto also affect trace requests.Also, add a
test/settingsendpoint to change the value of settings on the fly.