Fix OpenTracing doc #2188
Open
Fix OpenTracing doc #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 136 Passed, 3648 Skipped, 25.57s Total duration (2m 3.32s time saved) |
| @@ -52,10 +52,10 @@ public protocol OTSpan { | |||
| /// let span1 = tracer.startSpan(operationName: "root").setActive() | |||
| /// | |||
| /// // As `span2` has no explicit parent, it becomes the child of the active `span1`: | |||
There was a problem hiding this comment.
The span2 is now the active span right?
As span2 has no explicit parent, it becomes the active span
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
The following statement in OpenTracing doc is not true: If span has
nilparent, it becomes the child of the active span.How?
Update the doc and mention
startRootSpaninstead.Review checklist
make api-surface)