Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5579 chore: Rename IntegrationTests project to UITests #2189

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Feb 7, 2025

What and why?

📦 This PR renames the IntegrationTests project to UITests.

There are multiple motivations:

  • Remove confusion – We already have IntegrationUnitTests, which serves as our integration test target.
  • Reflect actual usage – In discussions, we keep referring to these as "UI Tests".
  • Maintains naming consistency – The new name aligns with other test categories in the repository root: SmokeTests, UITests, E2ETests, BenchmarkTests.

With this change, we can use clear, unambiguous test classifications:

  • Unit Tests
  • Integration Tests
  • UI Tests
  • Smoke Tests
  • Benchmark Tests
  • E2E Tests

How?

This change is purely a renaming of folders, configurations, and some files.

Notably, part of this work was already done during the GitLab migration project, where we introduced ui-test naming in Makefile commands:

make ui-test  
make ui-test-all  
make ui-test-podinstall  

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@ncreated ncreated self-assigned this Feb 7, 2025
@ncreated ncreated requested review from a team as code owners February 7, 2025 15:36
Copy link
Contributor

@simaoseica-dd simaoseica-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹

@@ -17,7 +17,7 @@
BlueprintIdentifier = "61441C2924616F1D003D8BB8"
BuildableName = "IntegrationScenarios.xctest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these BuildableName and BlueprintName should be renamed as well

cd "$DIR"

WORKSPACE="IntegrationTests/IntegrationTests.xcworkspace"
WORKSPACE="UITests/UITests.xcworkspace"
DESTINATION="platform=$platform,name=$device,OS=$os"
SCHEME="IntegrationScenarios"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UITestsScenarios?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants