-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the JDK's built-in support for Unix Domain Sockets on Java 16+ #8197
Draft
mcculls
wants to merge
1
commit into
master
Choose a base branch
from
mcculls/use-jdk-socket-support-on-java-16
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+223
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils/socket-utils/src/main/java17/datadog/common/socket/TunnelingJdkSocket.java
Show resolved
Hide resolved
mcculls
force-pushed
the
mcculls/use-jdk-socket-support-on-java-16
branch
2 times, most recently
from
January 14, 2025 14:56
f17db33
to
27676b4
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~b9373edbd0, baseline=1.46.0-SNAPSHOT~07e5d634ce
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060668
Total [baseline] (8.699 s) : 0, 8698594
Agent [candidate] (1.062 s) : 0, 1062474
Total [candidate] (8.623 s) : 0, 8622837
section iast
Agent [baseline] (1.183 s) : 0, 1182589
Total [baseline] (9.215 s) : 0, 9214602
Agent [candidate] (1.183 s) : 0, 1182782
Total [candidate] (9.211 s) : 0, 9210648
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1181061
Total [baseline] (9.189 s) : 0, 9188989
Agent [candidate] (1.183 s) : 0, 1182931
Total [candidate] (9.168 s) : 0, 9168199
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177644
Total [baseline] (9.229 s) : 0, 9229459
Agent [candidate] (1.176 s) : 0, 1176464
Total [candidate] (9.205 s) : 0, 9205235
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~b9373edbd0, baseline=1.46.0-SNAPSHOT~07e5d634ce
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.105 ms) : 0, 718105
BytebuddyAgent [candidate] (719.6 ms) : 0, 719600
GlobalTracer [baseline] (257.091 ms) : 0, 257091
GlobalTracer [candidate] (258.222 ms) : 0, 258222
AppSec [baseline] (55.354 ms) : 0, 55354
AppSec [candidate] (55.192 ms) : 0, 55192
Remote Config [baseline] (724.001 µs) : 0, 724
Remote Config [candidate] (738.025 µs) : 0, 738
Telemetry [baseline] (14.341 ms) : 0, 14341
Telemetry [candidate] (13.602 ms) : 0, 13602
section iast
BytebuddyAgent [baseline] (831.993 ms) : 0, 831993
BytebuddyAgent [candidate] (831.245 ms) : 0, 831245
GlobalTracer [baseline] (246.821 ms) : 0, 246821
GlobalTracer [candidate] (247.27 ms) : 0, 247270
AppSec [baseline] (57.183 ms) : 0, 57183
AppSec [candidate] (58.128 ms) : 0, 58128
IAST [baseline] (22.175 ms) : 0, 22175
IAST [candidate] (21.602 ms) : 0, 21602
Remote Config [baseline] (658.023 µs) : 0, 658
Remote Config [candidate] (672.171 µs) : 0, 672
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.846 ms) : 0, 8846
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.551 ms) : 0, 830551
BytebuddyAgent [candidate] (831.638 ms) : 0, 831638
GlobalTracer [baseline] (246.666 ms) : 0, 246666
GlobalTracer [candidate] (247.277 ms) : 0, 247277
AppSec [baseline] (57.999 ms) : 0, 57999
AppSec [candidate] (58.257 ms) : 0, 58257
IAST [baseline] (21.497 ms) : 0, 21497
IAST [candidate] (21.328 ms) : 0, 21328
Remote Config [baseline] (669.429 µs) : 0, 669
Remote Config [candidate] (670.788 µs) : 0, 671
Telemetry [baseline] (8.76 ms) : 0, 8760
Telemetry [candidate] (8.737 ms) : 0, 8737
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.826 ms) : 0, 827826
BytebuddyAgent [candidate] (827.582 ms) : 0, 827582
GlobalTracer [baseline] (246.601 ms) : 0, 246601
GlobalTracer [candidate] (246.29 ms) : 0, 246290
AppSec [baseline] (57.786 ms) : 0, 57786
AppSec [candidate] (57.472 ms) : 0, 57472
IAST [baseline] (21.052 ms) : 0, 21052
IAST [candidate] (20.903 ms) : 0, 20903
Remote Config [baseline] (673.942 µs) : 0, 674
Remote Config [candidate] (665.099 µs) : 0, 665
Telemetry [baseline] (8.717 ms) : 0, 8717
Telemetry [candidate] (8.565 ms) : 0, 8565
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~b9373edbd0, baseline=1.46.0-SNAPSHOT~07e5d634ce
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055246
Total [baseline] (10.495 s) : 0, 10494973
Agent [candidate] (1.057 s) : 0, 1057168
Total [candidate] (10.418 s) : 0, 10417895
section appsec
Agent [baseline] (1.186 s) : 0, 1186053
Total [baseline] (10.738 s) : 0, 10738114
Agent [candidate] (1.189 s) : 0, 1189385
Total [candidate] (10.692 s) : 0, 10692175
section iast
Agent [baseline] (1.185 s) : 0, 1185475
Total [baseline] (10.975 s) : 0, 10974790
Agent [candidate] (1.184 s) : 0, 1183878
Total [candidate] (10.967 s) : 0, 10967280
section profiling
Agent [baseline] (1.263 s) : 0, 1262813
Total [baseline] (10.89 s) : 0, 10889576
Agent [candidate] (1.26 s) : 0, 1260373
Total [candidate] (10.809 s) : 0, 10809405
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~b9373edbd0, baseline=1.46.0-SNAPSHOT~07e5d634ce
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.123 ms) : 0, 713123
BytebuddyAgent [candidate] (714.239 ms) : 0, 714239
GlobalTracer [baseline] (255.288 ms) : 0, 255288
GlobalTracer [candidate] (256.108 ms) : 0, 256108
AppSec [baseline] (55.349 ms) : 0, 55349
AppSec [candidate] (56.721 ms) : 0, 56721
Remote Config [baseline] (726.216 µs) : 0, 726
Remote Config [candidate] (718.216 µs) : 0, 718
Telemetry [baseline] (15.746 ms) : 0, 15746
Telemetry [candidate] (14.296 ms) : 0, 14296
section appsec
BytebuddyAgent [baseline] (729.557 ms) : 0, 729557
BytebuddyAgent [candidate] (732.066 ms) : 0, 732066
GlobalTracer [baseline] (252.356 ms) : 0, 252356
GlobalTracer [candidate] (253.402 ms) : 0, 253402
AppSec [baseline] (170.638 ms) : 0, 170638
AppSec [candidate] (169.938 ms) : 0, 169938
Remote Config [baseline] (674.656 µs) : 0, 675
Remote Config [candidate] (663.459 µs) : 0, 663
Telemetry [baseline] (8.209 ms) : 0, 8209
Telemetry [candidate] (8.566 ms) : 0, 8566
IAST [baseline] (19.356 ms) : 0, 19356
IAST [candidate] (19.402 ms) : 0, 19402
section iast
BytebuddyAgent [baseline] (835.062 ms) : 0, 835062
BytebuddyAgent [candidate] (833.809 ms) : 0, 833809
GlobalTracer [baseline] (246.271 ms) : 0, 246271
GlobalTracer [candidate] (246.303 ms) : 0, 246303
AppSec [baseline] (57.901 ms) : 0, 57901
AppSec [candidate] (57.865 ms) : 0, 57865
Remote Config [baseline] (685.771 µs) : 0, 686
Remote Config [candidate] (651.788 µs) : 0, 652
Telemetry [baseline] (8.86 ms) : 0, 8860
Telemetry [candidate] (8.714 ms) : 0, 8714
IAST [baseline] (21.643 ms) : 0, 21643
IAST [candidate] (21.415 ms) : 0, 21415
section profiling
ProfilingAgent [baseline] (96.006 ms) : 0, 96006
ProfilingAgent [candidate] (94.381 ms) : 0, 94381
BytebuddyAgent [baseline] (707.697 ms) : 0, 707697
BytebuddyAgent [candidate] (708.367 ms) : 0, 708367
GlobalTracer [baseline] (352.107 ms) : 0, 352107
GlobalTracer [candidate] (351.788 ms) : 0, 351788
AppSec [baseline] (55.149 ms) : 0, 55149
AppSec [candidate] (53.851 ms) : 0, 53851
Remote Config [baseline] (667.727 µs) : 0, 668
Remote Config [candidate] (650.679 µs) : 0, 651
Telemetry [baseline] (8.945 ms) : 0, 8945
Telemetry [candidate] (8.882 ms) : 0, 8882
Profiling [baseline] (96.033 ms) : 0, 96033
Profiling [candidate] (94.409 ms) : 0, 94409
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~b9373edbd0, baseline=1.46.0-SNAPSHOT~07e5d634ce
dateFormat X
axisFormat %s
section baseline
no_agent (1.37 ms) : 1350, 1389
. : milestone, 1370,
appsec (1.755 ms) : 1732, 1779
. : milestone, 1755,
appsec_no_iast (1.768 ms) : 1741, 1795
. : milestone, 1768,
iast (1.49 ms) : 1467, 1513
. : milestone, 1490,
profiling (1.542 ms) : 1517, 1567
. : milestone, 1542,
tracing (1.485 ms) : 1459, 1510
. : milestone, 1485,
section candidate
no_agent (1.357 ms) : 1338, 1377
. : milestone, 1357,
appsec (1.745 ms) : 1721, 1769
. : milestone, 1745,
appsec_no_iast (1.737 ms) : 1714, 1759
. : milestone, 1737,
iast (1.496 ms) : 1473, 1519
. : milestone, 1496,
profiling (1.511 ms) : 1488, 1534
. : milestone, 1511,
tracing (1.472 ms) : 1447, 1498
. : milestone, 1472,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~b9373edbd0, baseline=1.46.0-SNAPSHOT~07e5d634ce
dateFormat X
axisFormat %s
section baseline
no_agent (375.639 µs) : 356, 396
. : milestone, 376,
iast (494.912 µs) : 473, 517
. : milestone, 495,
iast_FULL (655.197 µs) : 634, 677
. : milestone, 655,
iast_GLOBAL (520.884 µs) : 499, 542
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (492.406 µs) : 471, 514
. : milestone, 492,
iast_INACTIVE (456.099 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (486.462 µs) : 465, 508
. : milestone, 486,
tracing (453.356 µs) : 432, 475
. : milestone, 453,
section candidate
no_agent (379.603 µs) : 358, 401
. : milestone, 380,
iast (502.134 µs) : 480, 524
. : milestone, 502,
iast_FULL (658.289 µs) : 636, 680
. : milestone, 658,
iast_GLOBAL (526.595 µs) : 504, 549
. : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (491.033 µs) : 470, 512
. : milestone, 491,
iast_INACTIVE (456.846 µs) : 436, 478
. : milestone, 457,
iast_TELEMETRY_OFF (489.89 µs) : 468, 512
. : milestone, 490,
tracing (449.78 µs) : 429, 471
. : milestone, 450,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~b9373edbd0, baseline=1.46.0-SNAPSHOT~07e5d634ce
dateFormat X
axisFormat %s
section baseline
no_agent (14.947 s) : 14947000, 14947000
. : milestone, 14947000,
appsec (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
iast (18.395 s) : 18395000, 18395000
. : milestone, 18395000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (15.176 s) : 15176000, 15176000
. : milestone, 15176000,
tracing (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
section candidate
no_agent (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
appsec (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
iast (18.961 s) : 18961000, 18961000
. : milestone, 18961000,
iast_GLOBAL (18.092 s) : 18092000, 18092000
. : milestone, 18092000,
profiling (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
tracing (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~b9373edbd0, baseline=1.46.0-SNAPSHOT~07e5d634ce
dateFormat X
axisFormat %s
section baseline
no_agent (1.448 ms) : 1437, 1459
. : milestone, 1448,
appsec (2.376 ms) : 2333, 2419
. : milestone, 2376,
iast (2.119 ms) : 2064, 2173
. : milestone, 2119,
iast_GLOBAL (2.157 ms) : 2103, 2212
. : milestone, 2157,
profiling (1.969 ms) : 1926, 2012
. : milestone, 1969,
tracing (1.962 ms) : 1920, 2004
. : milestone, 1962,
section candidate
no_agent (1.474 ms) : 1463, 1485
. : milestone, 1474,
appsec (2.372 ms) : 2329, 2415
. : milestone, 2372,
iast (2.11 ms) : 2055, 2164
. : milestone, 2110,
iast_GLOBAL (2.158 ms) : 2102, 2213
. : milestone, 2158,
profiling (1.995 ms) : 1951, 2040
. : milestone, 1995,
tracing (1.949 ms) : 1908, 1991
. : milestone, 1949,
|
mcculls
force-pushed
the
mcculls/use-jdk-socket-support-on-java-16
branch
from
January 14, 2025 17:04
27676b4
to
b9373ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMSP-1565