Change hash computation for protobuf to better represent impacting changes + save proto number in schema #8201

vandonr · 2025-01-14T16:35:59Z

What Does This Do

Change the way the hash is computed for protobuf schemas:

to catch some changes that impact the wire format but were not changing the hash before (like changing a field number for instance)
to stay constant on changes that don't impact the wire format, but were changing the hash before (like reorganizing fields without changing their number)
It should also be marginally faster as we don't hash a whole string, and also isolates the hash from json shennanigans like the OpenAPI version for instance.

This new hash computation is aligned with what's done in the dotnet version of the instrumentation in DataDog/dd-trace-dotnet#6166

ℹ️ Also add protobuf number to the OpenAPI schema saved, so that we can reconstruct the hash if needed, and also because it's an important component of a protobuf schema.

Additional Notes

Depending on how schema hashes are used now in DSM, when deploying this, it may look to users as if all their schemas changed

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-01-14T16:36:15Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-01-14T17:11:13Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/proto
git_commit_date	1736869642	1736872127
git_commit_sha	`5bb595b`	`9804100`
release_version	1.46.0-SNAPSHOT~5bb595bed0	1.46.0-SNAPSHOT~98041002a4

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736874627	1736874627
ci_job_id	765793491	765793491
ci_pipeline_id	52959981	52959981
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~98041002a4, baseline=1.46.0-SNAPSHOT~5bb595bed0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056348
Total [baseline] (10.394 s) : 0, 10393580
Agent [candidate] (1.055 s) : 0, 1055339
Total [candidate] (10.495 s) : 0, 10495357
section appsec
Agent [baseline] (1.192 s) : 0, 1191728
Total [baseline] (10.726 s) : 0, 10726229
Agent [candidate] (1.198 s) : 0, 1198379
Total [candidate] (10.746 s) : 0, 10746500
section iast
Agent [baseline] (1.183 s) : 0, 1182543
Total [baseline] (10.917 s) : 0, 10916889
Agent [candidate] (1.183 s) : 0, 1183444
Total [candidate] (10.986 s) : 0, 10986456
section profiling
Agent [baseline] (1.263 s) : 0, 1262704
Total [baseline] (10.847 s) : 0, 10846881
Agent [candidate] (1.26 s) : 0, 1260139
Total [candidate] (10.817 s) : 0, 10817008

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.056 s	-
Agent	appsec	1.192 s	135.38 ms (12.8%)
Agent	iast	1.183 s	126.195 ms (11.9%)
Agent	profiling	1.263 s	206.357 ms (19.5%)
Total	tracing	10.394 s	-
Total	appsec	10.726 s	332.649 ms (3.2%)
Total	iast	10.917 s	523.309 ms (5.0%)
Total	profiling	10.847 s	453.301 ms (4.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.198 s	143.04 ms (13.6%)
Agent	iast	1.183 s	128.105 ms (12.1%)
Agent	profiling	1.26 s	204.799 ms (19.4%)
Total	tracing	10.495 s	-
Total	appsec	10.746 s	251.143 ms (2.4%)
Total	iast	10.986 s	491.099 ms (4.7%)
Total	profiling	10.817 s	321.651 ms (3.1%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~98041002a4, baseline=1.46.0-SNAPSHOT~5bb595bed0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.265 ms) : 0, 714265
BytebuddyAgent [candidate] (713.123 ms) : 0, 713123
GlobalTracer [baseline] (255.816 ms) : 0, 255816
GlobalTracer [candidate] (255.584 ms) : 0, 255584
AppSec [baseline] (55.919 ms) : 0, 55919
AppSec [candidate] (55.034 ms) : 0, 55034
Remote Config [baseline] (725.776 µs) : 0, 726
Remote Config [candidate] (715.351 µs) : 0, 715
Telemetry [baseline] (14.581 ms) : 0, 14581
Telemetry [candidate] (15.856 ms) : 0, 15856
section appsec
BytebuddyAgent [baseline] (733.332 ms) : 0, 733332
BytebuddyAgent [candidate] (737.78 ms) : 0, 737780
GlobalTracer [baseline] (253.753 ms) : 0, 253753
GlobalTracer [candidate] (255.329 ms) : 0, 255329
AppSec [baseline] (170.993 ms) : 0, 170993
AppSec [candidate] (171.567 ms) : 0, 171567
Remote Config [baseline] (667.276 µs) : 0, 667
Remote Config [candidate] (674.858 µs) : 0, 675
Telemetry [baseline] (8.234 ms) : 0, 8234
Telemetry [candidate] (8.231 ms) : 0, 8231
IAST [baseline] (19.469 ms) : 0, 19469
IAST [candidate] (19.434 ms) : 0, 19434
section iast
BytebuddyAgent [baseline] (831.728 ms) : 0, 831728
BytebuddyAgent [candidate] (833.035 ms) : 0, 833035
GlobalTracer [baseline] (247.222 ms) : 0, 247222
GlobalTracer [candidate] (246.56 ms) : 0, 246560
AppSec [baseline] (57.816 ms) : 0, 57816
AppSec [candidate] (57.816 ms) : 0, 57816
Remote Config [baseline] (652.052 µs) : 0, 652
Remote Config [candidate] (675.067 µs) : 0, 675
Telemetry [baseline] (8.694 ms) : 0, 8694
Telemetry [candidate] (8.794 ms) : 0, 8794
IAST [baseline] (21.4 ms) : 0, 21400
IAST [candidate] (21.435 ms) : 0, 21435
section profiling
BytebuddyAgent [baseline] (708.816 ms) : 0, 708816
BytebuddyAgent [candidate] (707.977 ms) : 0, 707977
GlobalTracer [baseline] (351.263 ms) : 0, 351263
GlobalTracer [candidate] (350.756 ms) : 0, 350756
AppSec [baseline] (55.192 ms) : 0, 55192
AppSec [candidate] (53.92 ms) : 0, 53920
Remote Config [baseline] (657.376 µs) : 0, 657
Remote Config [candidate] (656.775 µs) : 0, 657
Telemetry [baseline] (8.824 ms) : 0, 8824
Telemetry [candidate] (8.856 ms) : 0, 8856
ProfilingAgent [baseline] (95.642 ms) : 0, 95642
ProfilingAgent [candidate] (95.62 ms) : 0, 95620
Profiling [baseline] (95.669 ms) : 0, 95669
Profiling [candidate] (95.647 ms) : 0, 95647

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~98041002a4, baseline=1.46.0-SNAPSHOT~5bb595bed0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058541
Total [baseline] (8.624 s) : 0, 8623501
Agent [candidate] (1.056 s) : 0, 1055881
Total [candidate] (8.641 s) : 0, 8640662
section iast
Agent [baseline] (1.205 s) : 0, 1204593
Total [baseline] (9.212 s) : 0, 9212069
Agent [candidate] (1.185 s) : 0, 1184962
Total [candidate] (9.181 s) : 0, 9180579
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.188 s) : 0, 1187519
Total [baseline] (9.194 s) : 0, 9194330
Agent [candidate] (1.182 s) : 0, 1181831
Total [candidate] (9.197 s) : 0, 9196905
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1192952
Total [baseline] (9.266 s) : 0, 9265793
Agent [candidate] (1.179 s) : 0, 1179465
Total [candidate] (9.201 s) : 0, 9200917

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.059 s	-
Agent	iast	1.205 s	146.052 ms (13.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.188 s	128.978 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.193 s	134.411 ms (12.7%)
Total	tracing	8.624 s	-
Total	iast	9.212 s	588.568 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.194 s	570.828 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.266 s	642.291 ms (7.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.056 s	-
Agent	iast	1.185 s	129.081 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.182 s	125.951 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.179 s	123.585 ms (11.7%)
Total	tracing	8.641 s	-
Total	iast	9.181 s	539.917 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.197 s	556.242 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.201 s	560.254 ms (6.5%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~98041002a4, baseline=1.46.0-SNAPSHOT~5bb595bed0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.5 ms) : 0, 716500
BytebuddyAgent [candidate] (713.903 ms) : 0, 713903
GlobalTracer [baseline] (255.431 ms) : 0, 255431
GlobalTracer [candidate] (256.017 ms) : 0, 256017
AppSec [baseline] (55.73 ms) : 0, 55730
AppSec [candidate] (57.303 ms) : 0, 57303
Remote Config [baseline] (714.561 µs) : 0, 715
Remote Config [candidate] (719.296 µs) : 0, 719
Telemetry [baseline] (15.057 ms) : 0, 15057
Telemetry [candidate] (12.902 ms) : 0, 12902
section iast
BytebuddyAgent [baseline] (848.405 ms) : 0, 848405
BytebuddyAgent [candidate] (833.474 ms) : 0, 833474
GlobalTracer [baseline] (250.587 ms) : 0, 250587
GlobalTracer [candidate] (247.429 ms) : 0, 247429
AppSec [baseline] (58.746 ms) : 0, 58746
AppSec [candidate] (58.181 ms) : 0, 58181
Remote Config [baseline] (698.525 µs) : 0, 699
Remote Config [candidate] (683.611 µs) : 0, 684
Telemetry [baseline] (8.995 ms) : 0, 8995
Telemetry [candidate] (8.687 ms) : 0, 8687
IAST [baseline] (21.811 ms) : 0, 21811
IAST [candidate] (21.377 ms) : 0, 21377
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.88 ms) : 0, 836880
BytebuddyAgent [candidate] (830.991 ms) : 0, 830991
GlobalTracer [baseline] (246.55 ms) : 0, 246550
GlobalTracer [candidate] (246.711 ms) : 0, 246711
AppSec [baseline] (58.042 ms) : 0, 58042
AppSec [candidate] (58.27 ms) : 0, 58270
Remote Config [baseline] (668.945 µs) : 0, 669
Remote Config [candidate] (701.522 µs) : 0, 702
Telemetry [baseline] (8.805 ms) : 0, 8805
Telemetry [candidate] (8.779 ms) : 0, 8779
IAST [baseline] (21.494 ms) : 0, 21494
IAST [candidate] (21.369 ms) : 0, 21369
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.723 ms) : 0, 839723
BytebuddyAgent [candidate] (828.931 ms) : 0, 828931
GlobalTracer [baseline] (249.043 ms) : 0, 249043
GlobalTracer [candidate] (247.069 ms) : 0, 247069
AppSec [baseline] (58.392 ms) : 0, 58392
AppSec [candidate] (57.962 ms) : 0, 57962
Remote Config [baseline] (696.582 µs) : 0, 697
Remote Config [candidate] (666.538 µs) : 0, 667
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.644 ms) : 0, 8644
IAST [baseline] (21.091 ms) : 0, 21091
IAST [candidate] (21.06 ms) : 0, 21060

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-14T16:40:26	2025-01-14T16:47:22
git_branch	master	vandonr/proto
git_commit_date	1736869642	1736872127
git_commit_sha	`5bb595b`	`9804100`
release_version	1.46.0-SNAPSHOT~5bb595bed0	1.46.0-SNAPSHOT~98041002a4
start_time	2025-01-14T16:40:12	2025-01-14T16:47:09

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736873596	1736873596
ci_job_id	765793493	765793493
ci_pipeline_id	52959981	52959981
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~98041002a4, baseline=1.46.0-SNAPSHOT~5bb595bed0
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.002 µs) : 363, 401
.   : milestone, 382,
iast (493.274 µs) : 472, 515
.   : milestone, 493,
iast_FULL (627.109 µs) : 605, 649
.   : milestone, 627,
iast_GLOBAL (523.758 µs) : 500, 547
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (486.781 µs) : 465, 508
.   : milestone, 487,
iast_INACTIVE (424.18 µs) : 403, 446
.   : milestone, 424,
iast_TELEMETRY_OFF (455.467 µs) : 433, 478
.   : milestone, 455,
tracing (448.531 µs) : 428, 469
.   : milestone, 449,
section candidate
no_agent (375.393 µs) : 355, 396
.   : milestone, 375,
iast (491.978 µs) : 471, 513
.   : milestone, 492,
iast_FULL (651.542 µs) : 630, 673
.   : milestone, 652,
iast_GLOBAL (524.425 µs) : 502, 547
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (491.466 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (451.405 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (481.016 µs) : 459, 503
.   : milestone, 481,
tracing (444.17 µs) : 424, 465
.   : milestone, 444,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.002 µs [362.559 µs, 401.445 µs]	-
iast	493.274 µs [471.584 µs, 514.963 µs]	111.271 µs (29.1%)
iast_FULL	627.109 µs [605.208 µs, 649.01 µs]	245.107 µs (64.2%)
iast_GLOBAL	523.758 µs [500.493 µs, 547.023 µs]	141.755 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED	486.781 µs [465.478 µs, 508.084 µs]	104.779 µs (27.4%)
iast_INACTIVE	424.18 µs [402.676 µs, 445.684 µs]	42.177 µs (11.0%)
iast_TELEMETRY_OFF	455.467 µs [433.373 µs, 477.561 µs]	73.465 µs (19.2%)
tracing	448.531 µs [427.766 µs, 469.297 µs]	66.529 µs (17.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.393 µs [355.22 µs, 395.565 µs]	-
iast	491.978 µs [470.587 µs, 513.369 µs]	116.585 µs (31.1%)
iast_FULL	651.542 µs [629.715 µs, 673.37 µs]	276.15 µs (73.6%)
iast_GLOBAL	524.425 µs [502.125 µs, 546.724 µs]	149.032 µs (39.7%)
iast_HARDCODED_SECRET_DISABLED	491.466 µs [469.718 µs, 513.215 µs]	116.074 µs (30.9%)
iast_INACTIVE	451.405 µs [430.355 µs, 472.455 µs]	76.012 µs (20.2%)
iast_TELEMETRY_OFF	481.016 µs [459.391 µs, 502.641 µs]	105.623 µs (28.1%)
tracing	444.17 µs [423.661 µs, 464.679 µs]	68.778 µs (18.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~98041002a4, baseline=1.46.0-SNAPSHOT~5bb595bed0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.39 ms) : 1369, 1410
.   : milestone, 1390,
appsec (1.749 ms) : 1723, 1774
.   : milestone, 1749,
appsec_no_iast (1.75 ms) : 1725, 1775
.   : milestone, 1750,
iast (1.504 ms) : 1481, 1527
.   : milestone, 1504,
profiling (1.496 ms) : 1471, 1520
.   : milestone, 1496,
tracing (1.472 ms) : 1447, 1497
.   : milestone, 1472,
section candidate
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.742 ms) : 1719, 1766
.   : milestone, 1742,
appsec_no_iast (1.761 ms) : 1737, 1784
.   : milestone, 1761,
iast (1.492 ms) : 1469, 1515
.   : milestone, 1492,
profiling (1.513 ms) : 1488, 1537
.   : milestone, 1513,
tracing (1.519 ms) : 1495, 1544
.   : milestone, 1519,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.39 ms [1.369 ms, 1.41 ms]	-
appsec	1.749 ms [1.723 ms, 1.774 ms]	358.843 µs (25.8%)
appsec_no_iast	1.75 ms [1.725 ms, 1.775 ms]	359.969 µs (25.9%)
iast	1.504 ms [1.481 ms, 1.527 ms]	114.23 µs (8.2%)
profiling	1.496 ms [1.471 ms, 1.52 ms]	105.992 µs (7.6%)
tracing	1.472 ms [1.447 ms, 1.497 ms]	82.383 µs (5.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.332 ms, 1.37 ms]	-
appsec	1.742 ms [1.719 ms, 1.766 ms]	391.74 µs (29.0%)
appsec_no_iast	1.761 ms [1.737 ms, 1.784 ms]	409.923 µs (30.3%)
iast	1.492 ms [1.469 ms, 1.515 ms]	141.506 µs (10.5%)
profiling	1.513 ms [1.488 ms, 1.537 ms]	161.868 µs (12.0%)
tracing	1.519 ms [1.495 ms, 1.544 ms]	168.795 µs (12.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/proto
git_commit_date	1736869642	1736872127
git_commit_sha	`5bb595b`	`9804100`
release_version	1.46.0-SNAPSHOT~5bb595bed0	1.46.0-SNAPSHOT~98041002a4

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1736874161	1736874161
ci_job_id	765793495	765793495
ci_pipeline_id	52959981	52959981
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~98041002a4, baseline=1.46.0-SNAPSHOT~5bb595bed0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.372 ms) : 2329, 2415
.   : milestone, 2372,
iast (2.118 ms) : 2063, 2172
.   : milestone, 2118,
iast_GLOBAL (2.162 ms) : 2107, 2217
.   : milestone, 2162,
profiling (1.987 ms) : 1943, 2031
.   : milestone, 1987,
tracing (1.97 ms) : 1927, 2012
.   : milestone, 1970,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.379 ms) : 2335, 2423
.   : milestone, 2379,
iast (2.115 ms) : 2060, 2169
.   : milestone, 2115,
iast_GLOBAL (2.162 ms) : 2107, 2217
.   : milestone, 2162,
profiling (2.489 ms) : 2298, 2680
.   : milestone, 2489,
tracing (1.956 ms) : 1913, 1998
.   : milestone, 1956,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.465 ms, 1.488 ms]	-
appsec	2.372 ms [2.329 ms, 2.415 ms]	895.215 µs (60.6%)
iast	2.118 ms [2.063 ms, 2.172 ms]	641.004 µs (43.4%)
iast_GLOBAL	2.162 ms [2.107 ms, 2.217 ms]	685.121 µs (46.4%)
profiling	1.987 ms [1.943 ms, 2.031 ms]	510.184 µs (34.6%)
tracing	1.97 ms [1.927 ms, 2.012 ms]	493.179 µs (33.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.457 ms, 1.48 ms]	-
appsec	2.379 ms [2.335 ms, 2.423 ms]	910.416 µs (62.0%)
iast	2.115 ms [2.06 ms, 2.169 ms]	646.107 µs (44.0%)
iast_GLOBAL	2.162 ms [2.107 ms, 2.217 ms]	693.744 µs (47.2%)
profiling	2.489 ms [2.298 ms, 2.68 ms]	1.02 ms (69.5%)
tracing	1.956 ms [1.913 ms, 1.998 ms]	487.231 µs (33.2%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~98041002a4, baseline=1.46.0-SNAPSHOT~5bb595bed0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
appsec (14.901 s) : 14901000, 14901000
.   : milestone, 14901000,
iast (18.679 s) : 18679000, 18679000
.   : milestone, 18679000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
.   : milestone, 17902000,
profiling (15.198 s) : 15198000, 15198000
.   : milestone, 15198000,
tracing (14.817 s) : 14817000, 14817000
.   : milestone, 14817000,
section candidate
no_agent (14.696 s) : 14696000, 14696000
.   : milestone, 14696000,
appsec (15.057 s) : 15057000, 15057000
.   : milestone, 15057000,
iast (18.72 s) : 18720000, 18720000
.   : milestone, 18720000,
iast_GLOBAL (18.261 s) : 18261000, 18261000
.   : milestone, 18261000,
profiling (14.93 s) : 14930000, 14930000
.   : milestone, 14930000,
tracing (14.799 s) : 14799000, 14799000
.   : milestone, 14799000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.027 s [15.027 s, 15.027 s]	-
appsec	14.901 s [14.901 s, 14.901 s]	-126.0 ms (-0.8%)
iast	18.679 s [18.679 s, 18.679 s]	3.652 s (24.3%)
iast_GLOBAL	17.902 s [17.902 s, 17.902 s]	2.875 s (19.1%)
profiling	15.198 s [15.198 s, 15.198 s]	171.0 ms (1.1%)
tracing	14.817 s [14.817 s, 14.817 s]	-210.0 ms (-1.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.696 s [14.696 s, 14.696 s]	-
appsec	15.057 s [15.057 s, 15.057 s]	361.0 ms (2.5%)
iast	18.72 s [18.72 s, 18.72 s]	4.024 s (27.4%)
iast_GLOBAL	18.261 s [18.261 s, 18.261 s]	3.565 s (24.3%)
profiling	14.93 s [14.93 s, 14.93 s]	234.0 ms (1.6%)
tracing	14.799 s [14.799 s, 14.799 s]	103.0 ms (0.7%)

change hash computation for protobuf to be closer to impacting changes

9804100

vandonr requested review from a team as code owners January 14, 2025 16:35

vandonr requested a review from smola January 14, 2025 16:36

vandonr added inst: protobuf Protocol Buffer instrumentation type: enhancement comp: data streams Data Streams Monitoring labels Jan 14, 2025

add protobuf number as extension to the saved schema

34cf5f7

vandonr changed the title ~~Change hash computation for protobuf to better represent impacting changes~~ Change hash computation for protobuf to better represent impacting changes + save proto number in schema Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change hash computation for protobuf to better represent impacting changes + save proto number in schema #8201

Change hash computation for protobuf to better represent impacting changes + save proto number in schema #8201

vandonr commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

pr-commenter bot commented Jan 14, 2025

Change hash computation for protobuf to better represent impacting changes + save proto number in schema #8201

Are you sure you want to change the base?

Change hash computation for protobuf to better represent impacting changes + save proto number in schema #8201

Conversation

vandonr commented Jan 14, 2025 • edited Loading

What Does This Do

Additional Notes

Contributor Checklist

github-actions bot commented Jan 14, 2025 • edited Loading

pr-commenter bot commented Jan 14, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

vandonr commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading