Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAST doesn't actively make remote calls, so never delay starting it #8294

Merged
merged 1 commit into from
Jan 28, 2025
Merged

IAST doesn't actively make remote calls, so never delay starting it #8294

merged 1 commit into from
Jan 28, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jan 28, 2025 •
edited by jira bot
Loading

Motivation

When OkHttp might trigger loading of java.util.logging we need to delay starting components that make remote calls. However there's no reason to delay starting components which don't actively make remote calls (if they record data that is sent out by another component then that's fine because the collected data will be sent when that component is started after premain.)

Contributor Checklist

Jira ticket: APMS-14233

@mcculls mcculls added type: enhancement comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Jan 28, 2025
@mcculls mcculls requested a review from a team as a code owner January 28, 2025 09:56
@mcculls mcculls requested a review from nayeem-kamal January 28, 2025 09:56
@mcculls mcculls added the comp: asm iast Application Security Management (IAST) label Jan 28, 2025
@mcculls mcculls requested a review from PerfectSlayer January 28, 2025 09:57
@mcculls mcculls force-pushed the mcculls/never-delay-iast branch from ce45369 to 818116f Compare January 28, 2025 10:20
@mcculls mcculls requested a review from a team as a code owner January 28, 2025 10:20
@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/never-delay-iast
git_commit_date 1738050055 1738059593
git_commit_sha e379305 818116f
release_version 1.46.0-SNAPSHOT~e3793055b5 1.46.0-SNAPSHOT~818116f820
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738061971 1738061971
ci_job_id 783098019 783098019
ci_pipeline_id 54166932 54166932
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xugqgpm8-project-304-concurrent-0-pw9iqz0w 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xugqgpm8-project-304-concurrent-0-pw9iqz0w 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 8 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:Remote Config better
[-76.008µs; -18.419µs] or [-11.510%; -2.789%]		 613.161µs 660.374µs
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:AppSec better
[-7.006ms; -1.657ms] or [-12.032%; -2.846%]		 53.897ms 58.229ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Remote Config better
[-61.297µs; -14.247µs] or [-9.380%; -2.180%]		 615.741µs 653.513µs
scenario:startup:petclinic:iast:AppSec better
[-6.001ms; -1.300ms] or [-10.320%; -2.235%]		 54.504ms 58.154ms
scenario:startup:petclinic:iast:Remote Config better
[-64.134µs; -19.286µs] or [-9.776%; -2.940%]		 614.332µs 656.042µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~818116f820, baseline=1.46.0-SNAPSHOT~e3793055b5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1036400
Total [baseline] (10.452 s) : 0, 10452489
Agent [candidate] (1.041 s) : 0, 1040954
Total [candidate] (10.501 s) : 0, 10500833
section appsec
Agent [baseline] (1.178 s) : 0, 1177800
Total [baseline] (10.752 s) : 0, 10751848
Agent [candidate] (1.184 s) : 0, 1184112
Total [candidate] (10.796 s) : 0, 10796309
section iast
Agent [baseline] (1.175 s) : 0, 1175386
Total [baseline] (10.959 s) : 0, 10959365
Agent [candidate] (1.176 s) : 0, 1176098
Total [candidate] (10.981 s) : 0, 10980798
section profiling
Agent [baseline] (1.262 s) : 0, 1261578
Total [baseline] (10.866 s) : 0, 10865839
Agent [candidate] (1.26 s) : 0, 1259586
Total [candidate] (10.861 s) : 0, 10861461
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent appsec 1.178 s 141.4 ms (13.6%)
Agent iast 1.175 s 138.986 ms (13.4%)
Agent profiling 1.262 s 225.178 ms (21.7%)
Total tracing 10.452 s -
Total appsec 10.752 s 299.36 ms (2.9%)
Total iast 10.959 s 506.876 ms (4.8%)
Total profiling 10.866 s 413.35 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.184 s 143.158 ms (13.8%)
Agent iast 1.176 s 135.145 ms (13.0%)
Agent profiling 1.26 s 218.632 ms (21.0%)
Total tracing 10.501 s -
Total appsec 10.796 s 295.476 ms (2.8%)
Total iast 10.981 s 479.965 ms (4.6%)
Total profiling 10.861 s 360.629 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~818116f820, baseline=1.46.0-SNAPSHOT~e3793055b5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.649 ms) : 0, 712649
BytebuddyAgent [candidate] (715.679 ms) : 0, 715679
GlobalTracer [baseline] (239.335 ms) : 0, 239335
GlobalTracer [candidate] (240.184 ms) : 0, 240184
AppSec [baseline] (55.682 ms) : 0, 55682
AppSec [candidate] (55.326 ms) : 0, 55326
Remote Config [baseline] (706.244 µs) : 0, 706
Remote Config [candidate] (721.599 µs) : 0, 722
Telemetry [baseline] (12.793 ms) : 0, 12793
Telemetry [candidate] (13.689 ms) : 0, 13689
section appsec
BytebuddyAgent [baseline] (730.704 ms) : 0, 730704
BytebuddyAgent [candidate] (734.205 ms) : 0, 734205
GlobalTracer [baseline] (236.847 ms) : 0, 236847
GlobalTracer [candidate] (238.028 ms) : 0, 238028
AppSec [baseline] (176.137 ms) : 0, 176137
AppSec [candidate] (176.717 ms) : 0, 176717
Remote Config [baseline] (645.75 µs) : 0, 646
Remote Config [candidate] (654.877 µs) : 0, 655
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (8.331 ms) : 0, 8331
IAST [baseline] (20.012 ms) : 0, 20012
IAST [candidate] (21.643 ms) : 0, 21643
section iast
BytebuddyAgent [baseline] (838.14 ms) : 0, 838140
BytebuddyAgent [candidate] (839.303 ms) : 0, 839303
GlobalTracer [baseline] (232.709 ms) : 0, 232709
GlobalTracer [candidate] (232.462 ms) : 0, 232462
AppSec [baseline] (58.154 ms) : 0, 58154
AppSec [candidate] (54.504 ms) : 0, 54504
Remote Config [baseline] (656.042 µs) : 0, 656
Remote Config [candidate] (614.332 µs) : 0, 614
Telemetry [baseline] (8.732 ms) : 0, 8732
Telemetry [candidate] (8.73 ms) : 0, 8730
IAST [baseline] (21.601 ms) : 0, 21601
IAST [candidate] (24.973 ms) : 0, 24973
section profiling
ProfilingAgent [baseline] (97.11 ms) : 0, 97110
ProfilingAgent [candidate] (95.819 ms) : 0, 95819
BytebuddyAgent [baseline] (706.704 ms) : 0, 706704
BytebuddyAgent [candidate] (706.732 ms) : 0, 706732
GlobalTracer [baseline] (350.167 ms) : 0, 350167
GlobalTracer [candidate] (350.786 ms) : 0, 350786
AppSec [baseline] (55.383 ms) : 0, 55383
AppSec [candidate] (54.356 ms) : 0, 54356
Remote Config [baseline] (709.535 µs) : 0, 710
Remote Config [candidate] (696.976 µs) : 0, 697
Telemetry [baseline] (8.861 ms) : 0, 8861
Telemetry [candidate] (8.868 ms) : 0, 8868
Profiling [baseline] (97.133 ms) : 0, 97133
Profiling [candidate] (95.842 ms) : 0, 95842
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~818116f820, baseline=1.46.0-SNAPSHOT~e3793055b5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1038082
Total [baseline] (8.643 s) : 0, 8642570
Agent [candidate] (1.036 s) : 0, 1036090
Total [candidate] (8.663 s) : 0, 8662963
section iast
Agent [baseline] (1.171 s) : 0, 1171152
Total [baseline] (9.236 s) : 0, 9236097
Agent [candidate] (1.179 s) : 0, 1179281
Total [candidate] (9.272 s) : 0, 9272437
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.166 s) : 0, 1166216
Total [baseline] (9.192 s) : 0, 9192085
Agent [candidate] (1.169 s) : 0, 1169141
Total [candidate] (9.203 s) : 0, 9203336
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1162951
Total [baseline] (9.228 s) : 0, 9227714
Agent [candidate] (1.166 s) : 0, 1165575
Total [candidate] (9.233 s) : 0, 9232600
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.038 s -
Agent iast 1.171 s 133.07 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.166 s 128.134 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.163 s 124.87 ms (12.0%)
Total tracing 8.643 s -
Total iast 9.236 s 593.527 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.192 s 549.515 ms (6.4%)
Total iast_TELEMETRY_OFF 9.228 s 585.144 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent iast 1.179 s 143.191 ms (13.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 133.051 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.166 s 129.486 ms (12.5%)
Total tracing 8.663 s -
Total iast 9.272 s 609.474 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.203 s 540.373 ms (6.2%)
Total iast_TELEMETRY_OFF 9.233 s 569.637 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~818116f820, baseline=1.46.0-SNAPSHOT~e3793055b5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.734 ms) : 0, 713734
BytebuddyAgent [candidate] (712.95 ms) : 0, 712950
GlobalTracer [baseline] (240.918 ms) : 0, 240918
GlobalTracer [candidate] (239.295 ms) : 0, 239295
AppSec [baseline] (55.873 ms) : 0, 55873
AppSec [candidate] (55.1 ms) : 0, 55100
Remote Config [baseline] (749.06 µs) : 0, 749
Remote Config [candidate] (707.603 µs) : 0, 708
Telemetry [baseline] (11.561 ms) : 0, 11561
Telemetry [candidate] (12.8 ms) : 0, 12800
section iast
BytebuddyAgent [baseline] (835.828 ms) : 0, 835828
BytebuddyAgent [candidate] (841.558 ms) : 0, 841558
GlobalTracer [baseline] (231.275 ms) : 0, 231275
GlobalTracer [candidate] (232.638 ms) : 0, 232638
AppSec [baseline] (57.96 ms) : 0, 57960
AppSec [candidate] (54.197 ms) : 0, 54197
Remote Config [baseline] (660.374 µs) : 0, 660
Remote Config [candidate] (613.161 µs) : 0, 613
Telemetry [baseline] (8.695 ms) : 0, 8695
Telemetry [candidate] (8.897 ms) : 0, 8897
IAST [baseline] (21.396 ms) : 0, 21396
IAST [candidate] (25.81 ms) : 0, 25810
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.381 ms) : 0, 832381
BytebuddyAgent [candidate] (833.784 ms) : 0, 833784
GlobalTracer [baseline] (230.257 ms) : 0, 230257
GlobalTracer [candidate] (230.998 ms) : 0, 230998
AppSec [baseline] (57.718 ms) : 0, 57718
AppSec [candidate] (53.074 ms) : 0, 53074
Remote Config [baseline] (638.519 µs) : 0, 639
Remote Config [candidate] (617.738 µs) : 0, 618
Telemetry [baseline] (8.589 ms) : 0, 8589
Telemetry [candidate] (8.745 ms) : 0, 8745
IAST [baseline] (21.267 ms) : 0, 21267
IAST [candidate] (25.846 ms) : 0, 25846
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.393 ms) : 0, 829393
BytebuddyAgent [candidate] (831.658 ms) : 0, 831658
GlobalTracer [baseline] (229.802 ms) : 0, 229802
GlobalTracer [candidate] (230.706 ms) : 0, 230706
AppSec [baseline] (58.229 ms) : 0, 58229
AppSec [candidate] (53.897 ms) : 0, 53897
Remote Config [baseline] (653.513 µs) : 0, 654
Remote Config [candidate] (615.741 µs) : 0, 616
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.47 ms) : 0, 8470
IAST [baseline] (20.982 ms) : 0, 20982
IAST [candidate] (24.833 ms) : 0, 24833
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-28T10:29:26 2025-01-28T10:36:30
git_branch master mcculls/never-delay-iast
git_commit_date 1738050055 1738059593
git_commit_sha e379305 818116f
release_version 1.46.0-SNAPSHOT~e3793055b5 1.46.0-SNAPSHOT~818116f820
start_time 2025-01-28T10:29:12 2025-01-28T10:36:16
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738060949 1738060949
ci_job_id 783098020 783098020
ci_pipeline_id 54166932 54166932
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-4p1cqabb-project-304-concurrent-1-2z5qvoca 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-4p1cqabb-project-304-concurrent-1-2z5qvoca 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~818116f820, baseline=1.46.0-SNAPSHOT~e3793055b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1378
.   : milestone, 1357,
appsec (1.742 ms) : 1718, 1765
.   : milestone, 1742,
appsec_no_iast (1.768 ms) : 1744, 1793
.   : milestone, 1768,
iast (1.509 ms) : 1485, 1533
.   : milestone, 1509,
profiling (1.5 ms) : 1476, 1523
.   : milestone, 1500,
tracing (1.498 ms) : 1474, 1521
.   : milestone, 1498,
section candidate
no_agent (1.37 ms) : 1349, 1390
.   : milestone, 1370,
appsec (1.749 ms) : 1726, 1773
.   : milestone, 1749,
appsec_no_iast (1.771 ms) : 1745, 1797
.   : milestone, 1771,
iast (1.486 ms) : 1462, 1510
.   : milestone, 1486,
profiling (1.508 ms) : 1484, 1532
.   : milestone, 1508,
tracing (1.487 ms) : 1462, 1512
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.337 ms, 1.378 ms] -
appsec 1.742 ms [1.718 ms, 1.765 ms] 384.379 µs (28.3%)
appsec_no_iast 1.768 ms [1.744 ms, 1.793 ms] 410.807 µs (30.3%)
iast 1.509 ms [1.485 ms, 1.533 ms] 151.632 µs (11.2%)
profiling 1.5 ms [1.476 ms, 1.523 ms] 142.371 µs (10.5%)
tracing 1.498 ms [1.474 ms, 1.521 ms] 140.275 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.349 ms, 1.39 ms] -
appsec 1.749 ms [1.726 ms, 1.773 ms] 379.451 µs (27.7%)
appsec_no_iast 1.771 ms [1.745 ms, 1.797 ms] 401.185 µs (29.3%)
iast 1.486 ms [1.462 ms, 1.51 ms] 116.494 µs (8.5%)
profiling 1.508 ms [1.484 ms, 1.532 ms] 138.801 µs (10.1%)
tracing 1.487 ms [1.462 ms, 1.512 ms] 117.393 µs (8.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~818116f820, baseline=1.46.0-SNAPSHOT~e3793055b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.981 µs) : 362, 402
.   : milestone, 382,
iast (515.741 µs) : 494, 538
.   : milestone, 516,
iast_FULL (744.005 µs) : 721, 767
.   : milestone, 744,
iast_GLOBAL (564.757 µs) : 541, 588
.   : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (507.351 µs) : 485, 530
.   : milestone, 507,
iast_INACTIVE (462.614 µs) : 441, 484
.   : milestone, 463,
iast_TELEMETRY_OFF (504.043 µs) : 481, 527
.   : milestone, 504,
tracing (450.7 µs) : 430, 471
.   : milestone, 451,
section candidate
no_agent (379.938 µs) : 360, 400
.   : milestone, 380,
iast (507.792 µs) : 485, 531
.   : milestone, 508,
iast_FULL (745.436 µs) : 723, 768
.   : milestone, 745,
iast_GLOBAL (568.602 µs) : 544, 594
.   : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (517.827 µs) : 494, 541
.   : milestone, 518,
iast_INACTIVE (459.47 µs) : 438, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (502.4 µs) : 480, 525
.   : milestone, 502,
tracing (459.082 µs) : 438, 480
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.981 µs [362.419 µs, 401.543 µs] -
iast 515.741 µs [493.972 µs, 537.51 µs] 133.76 µs (35.0%)
iast_FULL 744.005 µs [720.828 µs, 767.182 µs] 362.024 µs (94.8%)
iast_GLOBAL 564.757 µs [541.204 µs, 588.311 µs] 182.776 µs (47.8%)
iast_HARDCODED_SECRET_DISABLED 507.351 µs [484.595 µs, 530.107 µs] 125.37 µs (32.8%)
iast_INACTIVE 462.614 µs [441.127 µs, 484.101 µs] 80.633 µs (21.1%)
iast_TELEMETRY_OFF 504.043 µs [480.815 µs, 527.271 µs] 122.062 µs (32.0%)
tracing 450.7 µs [430.103 µs, 471.296 µs] 68.719 µs (18.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.938 µs [360.258 µs, 399.618 µs] -
iast 507.792 µs [484.795 µs, 530.789 µs] 127.854 µs (33.7%)
iast_FULL 745.436 µs [723.357 µs, 767.516 µs] 365.498 µs (96.2%)
iast_GLOBAL 568.602 µs [543.667 µs, 593.536 µs] 188.664 µs (49.7%)
iast_HARDCODED_SECRET_DISABLED 517.827 µs [494.224 µs, 541.43 µs] 137.889 µs (36.3%)
iast_INACTIVE 459.47 µs [437.869 µs, 481.071 µs] 79.532 µs (20.9%)
iast_TELEMETRY_OFF 502.4 µs [479.673 µs, 525.128 µs] 122.462 µs (32.2%)
tracing 459.082 µs [438.334 µs, 479.83 µs] 79.144 µs (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/never-delay-iast
git_commit_date 1738050055 1738059593
git_commit_sha e379305 818116f
release_version 1.46.0-SNAPSHOT~e3793055b5 1.46.0-SNAPSHOT~818116f820
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1738061677 1738061677
ci_job_id 783098021 783098021
ci_pipeline_id 54166932 54166932
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-hu1gnouc-project-304-concurrent-0-hynh595t 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-hu1gnouc-project-304-concurrent-0-hynh595t 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~818116f820, baseline=1.46.0-SNAPSHOT~e3793055b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
appsec (15.065 s) : 15065000, 15065000
.   : milestone, 15065000,
iast (18.867 s) : 18867000, 18867000
.   : milestone, 18867000,
iast_GLOBAL (18.23 s) : 18230000, 18230000
.   : milestone, 18230000,
profiling (15.096 s) : 15096000, 15096000
.   : milestone, 15096000,
tracing (15.088 s) : 15088000, 15088000
.   : milestone, 15088000,
section candidate
no_agent (15.434 s) : 15434000, 15434000
.   : milestone, 15434000,
appsec (15.225 s) : 15225000, 15225000
.   : milestone, 15225000,
iast (18.411 s) : 18411000, 18411000
.   : milestone, 18411000,
iast_GLOBAL (18.204 s) : 18204000, 18204000
.   : milestone, 18204000,
profiling (15.499 s) : 15499000, 15499000
.   : milestone, 15499000,
tracing (14.89 s) : 14890000, 14890000
.   : milestone, 14890000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.279 s [15.279 s, 15.279 s] -
appsec 15.065 s [15.065 s, 15.065 s] -214.0 ms (-1.4%)
iast 18.867 s [18.867 s, 18.867 s] 3.588 s (23.5%)
iast_GLOBAL 18.23 s [18.23 s, 18.23 s] 2.951 s (19.3%)
profiling 15.096 s [15.096 s, 15.096 s] -183.0 ms (-1.2%)
tracing 15.088 s [15.088 s, 15.088 s] -191.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.434 s [15.434 s, 15.434 s] -
appsec 15.225 s [15.225 s, 15.225 s] -209.0 ms (-1.4%)
iast 18.411 s [18.411 s, 18.411 s] 2.977 s (19.3%)
iast_GLOBAL 18.204 s [18.204 s, 18.204 s] 2.77 s (17.9%)
profiling 15.499 s [15.499 s, 15.499 s] 65.0 ms (0.4%)
tracing 14.89 s [14.89 s, 14.89 s] -544.0 ms (-3.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~818116f820, baseline=1.46.0-SNAPSHOT~e3793055b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.368 ms) : 2325, 2411
.   : milestone, 2368,
iast (2.113 ms) : 2059, 2168
.   : milestone, 2113,
iast_GLOBAL (2.157 ms) : 2102, 2213
.   : milestone, 2157,
profiling (2.464 ms) : 2273, 2655
.   : milestone, 2464,
tracing (1.961 ms) : 1918, 2004
.   : milestone, 1961,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.375 ms) : 2331, 2418
.   : milestone, 2375,
iast (2.107 ms) : 2052, 2162
.   : milestone, 2107,
iast_GLOBAL (2.174 ms) : 2119, 2229
.   : milestone, 2174,
profiling (2.006 ms) : 1961, 2051
.   : milestone, 2006,
tracing (1.965 ms) : 1923, 2008
.   : milestone, 1965,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 2.368 ms [2.325 ms, 2.411 ms] 890.575 µs (60.3%)
iast 2.113 ms [2.059 ms, 2.168 ms] 635.96 µs (43.1%)
iast_GLOBAL 2.157 ms [2.102 ms, 2.213 ms] 680.121 µs (46.0%)
profiling 2.464 ms [2.273 ms, 2.655 ms] 986.717 µs (66.8%)
tracing 1.961 ms [1.918 ms, 2.004 ms] 483.733 µs (32.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.375 ms [2.331 ms, 2.418 ms] 903.929 µs (61.5%)
iast 2.107 ms [2.052 ms, 2.162 ms] 636.541 µs (43.3%)
iast_GLOBAL 2.174 ms [2.119 ms, 2.229 ms] 703.307 µs (47.8%)
profiling 2.006 ms [1.961 ms, 2.051 ms] 535.796 µs (36.4%)
tracing 1.965 ms [1.923 ms, 2.008 ms] 494.87 µs (33.7%)

@mcculls mcculls added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jan 28, 2025
@mcculls mcculls enabled auto-merge (squash) January 28, 2025 11:56
amarziali
amarziali approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mcculls mcculls merged commit 95f2490 into master Jan 28, 2025
195 of 196 checks passed
@mcculls mcculls deleted the mcculls/never-delay-iast branch January 28, 2025 13:30
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) comp: core Tracer core tag: no release notes Changes to exclude from release notes type: enhancement
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali