fix(logging): remove unneeded forksafe unregister to avoid unneeded logging

[ZStriker19]

Removes unneeded forksafe unregister hook. The unregister is not needed, because we never actually registered the hook to begin with.

Checklist

• PR author has checked that all the criteria below are met
• The PR description includes an overview of the change
• The PR description articulates the motivation for the change
• The change includes tests OR the PR description describes a testing strategy
• The PR description notes risks associated with the change, if any
• Newly-added code is easy to change
• The change follows the library release note guidelines
• The change includes or references documentation updates if necessary
• Backport labels are set (if applicable)

Reviewer Checklist

• Reviewer has checked that all the criteria below are met
• Title is accurate
• All changes are related to the pull request's stated goal
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Newly-added code is easy to change
• Release note makes sense to a user of the library
• If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[github-actions]

CODEOWNERS have been resolved as:

releasenotes/notes/remove_unneeded_unregister-ad20120201768a7e.yaml     @DataDog/apm-python
ddtrace/internal/remoteconfig/worker.py                                 @DataDog/remote-config @DataDog/apm-core-python

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-02-04 22:43:30

Comparing candidate commit 423e634 in PR branch zachg/remove_unneeded_unregister with baseline commit e294f47 in branch 3.x-staging.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathjoin_aspect

• 🟩 execution_time [-519.096ns; -456.141ns] or [-9.293%; -8.166%]

[P403n1x87]

Well spotted. I think we can remove the atexit too as this is now handled by the product interface protocol

dd-trace-py/ddtrace/internal/remoteconfig/product.py

Lines 28 to 29 in 40ebba6

	remoteconfig_poller.disable(join=join)

[ZStriker19]

Ah I see, I was definitely wondering about what else could be removed given the introduction of that, but I wasn't sure. Thank you!