Clarify change log section instructions for contributors. #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely, contributors can skip the change log section and it will be filled out during PR review. Also moved the change log section below explanation of changes which should make the template easier to fill out for contributors, and comment out the review request note since it doesn't need to be part of PR text.
p-datadog
force-pushed
the
pr-template-changelog
branch
from
fb0b017 to
9e5fccd
Compare
p-datadog
added
the
dev/internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4021 +/- ##
==========================================
- Coverage 97.86% 97.84% -0.02%
==========================================
Files 1319 1319
Lines 79157 79157
Branches 3929 3929
==========================================
- Hits 77466 77452 -14
- Misses 1691 1705 +14 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-10-23 15:48:14 Comparing candidate commit 9e5fccd in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics. scenario:profiler - gvl benchmark samples
scenario:tracing - Propagation - Trace Context
|
y9v
approved these changes
Oct 23, 2024
ivoanjo
approved these changes
Oct 24, 2024
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Oct 24, 2024
* master: (34 commits) Clarify change log section instructions for contributors. (DataDog#4021) Minor: Split heap recorder stats into young/non-young Minor: Align `heap_clean_after_gc_enabled` native default value with actual default Add test coverage for minimum period between heap updates Add test coverage for not updating heap half-way during serialization Add benchmarking variant for heap with clean after GC Remove "only-profiling-alloc-ddprof" testing configuration Introduce setting to control heap clean after GC Convert `StackRecorder._native_initialize` to use kw args Introduce `StackRecorder.for_testing` helper Add unit test for heap cleanup after GC only testing young objects Add integration-style spec for heap cleanup after GC Fix segfaults when calling `_native_debug_heap_recorder` in tests Add TODO on metrics to discuss with @AlexJF Optimization: Skip updating object sizes when not doing a full update Minor: Tweak exception error message Hide `heap_recorder_update` from heap recorder API Simplify `heap_recorder_update` logic now that `full_update` decision comes from outside Remove `last_update_major_gc_since` as it was not working Continue refactoring heap cleanup after GC to be best-effort ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR clarifies change log section instructions for contributors.
Namely, contributors can skip the change log section and it will be filled out during PR review.
Also moved the change log section below explanation of changes which should make the template easier to fill out for contributors, and comment out the review request note since it doesn't need to be part of PR text.
Motivation:
Feedback in #4005