Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ffi to 1.17 for gemfiles/*lock #4057

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Update ffi to 1.17 for gemfiles/*lock #4057

merged 2 commits into from
Nov 1, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 1, 2024

What does this PR do?

Udpate ffi to 1.17 for gemfiles/*lock

Note: ffi 1.17.0 ships binary gems for each platform, However does not ship binaries for ruby 3.4

@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 1, 2024 12:23
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 1, 2024 12:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (17007f7) to head (13d5889).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4057      +/-   ##
==========================================
- Coverage   97.73%   97.72%   -0.02%     
==========================================
  Files        1338     1338              
  Lines       80248    80248              
  Branches     4016     4016              
==========================================
- Hits        78434    78421      -13     
- Misses       1814     1827      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Nov 1, 2024

Benchmarks

Benchmark execution time: 2024-11-01 12:39:34

Comparing candidate commit 13d5889 in PR branch tonycthsu/ffi with baseline commit 17007f7 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.599op/s; -0.577op/s] or [-8.781%; -8.459%]

@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Nov 1, 2024
@TonyCTHsu TonyCTHsu merged commit 922d8ff into master Nov 1, 2024
277 of 280 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/ffi branch November 1, 2024 14:07
@github-actions github-actions bot added this to the 2.5.0 milestone Nov 1, 2024
@ivoanjo ivoanjo changed the title Udpate ffi to 1.17 for gemfiles/*lock Update ffi to 1.17 for gemfiles/*lock Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants