Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Datadog testagent version from 1.18.0 to 1.12.0 #4060

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Nov 1, 2024

What does this PR do?
This PR changes the Datadog testagent version from 1.18.0 back to 1.12.0 in the docker-compose.yml and .circleci/config.yml.

Motivation:
Testagent v1.18.0 causes local tracing parsing errors, such as: ERROR -- datadog: [datadog] (/app/lib/datadog/tracing/transport/http/client.rb:42:in 'rescue in send_request') Internal error during Datadog::Tracing::Transport::HTTP::Client request. Cause: JSON::ParserError unexpected token at '{"rate_by_service": {"service:,e' Location: /usr/local/bundle/gems/json-2.7.5/lib/json/common.rb:220:in 'parse'. No particular functionality of v1.18.0 was needed, and reverting the version to 1.12.0 fixes these errors.

Change log entry
No change log entry needed.

Additional Notes:
N/A

How to test the change?
To test this change, run docker compose run --rm -it tracer-<version number> bash -c "rm *lock && bundle install && bundle exec rake spec:main" locally. All tests should pass, whereas previously, you would see many tracing errors.

@sarahchen6 sarahchen6 marked this pull request as ready for review November 1, 2024 19:44
@sarahchen6 sarahchen6 requested a review from a team as a code owner November 1, 2024 19:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (51446c7) to head (13c845f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4060      +/-   ##
==========================================
+ Coverage   97.72%   97.73%   +0.01%     
==========================================
  Files        1338     1338              
  Lines       80249    80249              
  Branches     4016     4016              
==========================================
+ Hits        78422    78431       +9     
+ Misses       1827     1818       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Nov 1, 2024

Benchmarks

Benchmark execution time: 2024-11-01 20:07:37

Comparing candidate commit 13c845f in PR branch sarahchen6/revert-testagent-version with baseline commit 51446c7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right!

@ivoanjo
Copy link
Member

ivoanjo commented Nov 4, 2024

I'm guessing this is the "stop the bleeding PR" which makes sense; but we should also make sure to ping the folks that maintain the test agent to let them know that 1.18.0 appears broken, as permanently staying on an old version doesn't seem great.

@TonyCTHsu TonyCTHsu enabled auto-merge November 4, 2024 10:55
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Nov 4, 2024
@TonyCTHsu TonyCTHsu merged commit 7948a96 into master Nov 4, 2024
275 checks passed
@TonyCTHsu TonyCTHsu deleted the sarahchen6/revert-testagent-version branch November 4, 2024 16:07
@github-actions github-actions bot added this to the 2.5.0 milestone Nov 4, 2024
@sarahchen6
Copy link
Contributor Author

I'm guessing this is the "stop the bleeding PR" which makes sense; but we should also make sure to ping the folks that maintain the test agent to let them know that 1.18.0 appears broken, as permanently staying on an old version doesn't seem great.

I agree. Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants