Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard to development guide #4242

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Add standard to development guide #4242

merged 2 commits into from
Jan 3, 2025

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Dec 25, 2024

What does this PR do?
Adds a mention of standard to the development guide, used currently for profiling and DI.

Motivation:
Improving developer experience

Change log entry
None

Additional Notes:

How to test the change?

N/A

@p-datadog p-datadog requested a review from a team as a code owner December 25, 2024 16:52
@github-actions github-actions bot added the docs Involves documentation label Dec 25, 2024
@p-datadog p-datadog added integrations Involves tracing integrations dev/internal Other internal work that does not need to be included in the changelog and removed integrations Involves tracing integrations labels Dec 25, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 25, 2024

Datadog Report

Branch report: standard-dev-guide
Commit report: c36eda7
Test service: dd-trace-rb

✅ 0 Failed, 22140 Passed, 1471 Skipped, 6m 17.12s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 25, 2024

Benchmarks

Benchmark execution time: 2025-01-03 10:27:40

Comparing candidate commit c36eda7 in PR branch standard-dev-guide with baseline commit b1400d5 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (b1400d5) to head (c36eda7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4242      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files        1353     1353              
  Lines       82392    82392              
  Branches     4224     4224              
==========================================
- Hits        80550    80543       -7     
- Misses       1842     1849       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-datadog p-datadog merged commit f3e66ea into master Jan 3, 2025
337 checks passed
@p-datadog p-datadog deleted the standard-dev-guide branch January 3, 2025 21:04
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants