-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integrations images build script #4243
Conversation
Remove pre-2.5 image builds commands since the minimum Ruby version we now support is 2.5. Add 3.4 as a supported Ruby version to the help text (it is already handled by the script).
789636f
to
18140fc
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22119 Passed, 1477 Skipped, 6m 12.69s Total Time |
BenchmarksBenchmark execution time: 2025-01-03 10:27:23 Comparing candidate commit da34bfc in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - hold / resume
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the cleanup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4243 +/- ##
==========================================
- Coverage 97.76% 97.75% -0.01%
==========================================
Files 1353 1353
Lines 82392 82392
Branches 4224 4224
==========================================
- Hits 80550 80542 -8
- Misses 1842 1850 +8 ☔ View full report in Codecov by Sentry. |
What does this PR do?
Remove pre-2.5 image builds commands since the minimum Ruby version we now support is 2.5.
Add 3.4 as a supported Ruby version to the help text (it is already handled by the script).
Motivation:
Researching how to perform integration testing of DI.
Change log entry
None
Additional Notes:
How to test the change?
N/A