Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integrations images build script #4243

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

p-datadog
Copy link
Member

What does this PR do?
Remove pre-2.5 image builds commands since the minimum Ruby version we now support is 2.5.

Add 3.4 as a supported Ruby version to the help text (it is already handled by the script).

Motivation:
Researching how to perform integration testing of DI.

Change log entry
None

Additional Notes:

How to test the change?
N/A

@p-datadog p-datadog requested a review from a team as a code owner December 25, 2024 16:53
@p-datadog p-datadog added the dev/internal Other internal work that does not need to be included in the changelog label Dec 25, 2024
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Dec 25, 2024
Remove pre-2.5 image builds commands since the minimum Ruby
version we now support is 2.5.

Add 3.4 as a supported Ruby version to the help text
(it is already handled by the script).
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 25, 2024

Datadog Report

Branch report: integrations-build
Commit report: da34bfc
Test service: dd-trace-rb

✅ 0 Failed, 22119 Passed, 1477 Skipped, 6m 12.69s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 25, 2024

Benchmarks

Benchmark execution time: 2025-01-03 10:27:23

Comparing candidate commit da34bfc in PR branch integrations-build with baseline commit b1400d5 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - hold / resume

  • 🟩 throughput [+114769.730op/s; +116198.819op/s] or [+7.204%; +7.293%]

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the cleanup

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (b1400d5) to head (da34bfc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4243      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files        1353     1353              
  Lines       82392    82392              
  Branches     4224     4224              
==========================================
- Hits        80550    80542       -8     
- Misses       1842     1850       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-datadog p-datadog merged commit 6fc4c8e into master Jan 3, 2025
337 checks passed
@p-datadog p-datadog deleted the integrations-build branch January 3, 2025 21:04
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants