[NOTICKET-1] use Ruby 3.4.1 for test-memcheck GHA + other fixes to bring master CI to green with 3.4 #4247
Conversation
github-actions
bot
added
the
dev/github
Datadog ReportBranch report: ✅ 0 Failed, 22114 Passed, 1476 Skipped, 5m 56.8s Total Time |
BenchmarksBenchmark execution time: 2025-01-02 16:44:01 Comparing candidate commit f88e1c1 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Datadog
|
… leak Since our exceptions match on the stack, they are affected by internal naming changes, and it looks like a new `ruby_xcalloc_body` function is now showing up in the stack.
This is waaay incomplete in terms of adding support for Ruby 3.5 but should get us going for ASAN testing for now.
In practice this shouldn't make a difference, since the final lockfiles are supposed to be a superset of the root-level gemfile BUT the `Appraisals` file no longer exists anyway and "just in case" let's have it anyway as it seems more correct.
This is not expected to be an issue in 3.5 (and is probably fixed for 3.4 as well, but I'll leave that for a separate PR to not affect the appraisals).
ivoanjo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4247 +/- ##
==========================================
+ Coverage 97.74% 97.75% +0.01%
==========================================
Files 1355 1355
Lines 82365 82366 +1
Branches 4230 4230
==========================================
+ Hits 80510 80520 +10
+ Misses 1855 1846 -9 ☔ View full report in Codecov by Sentry. |
|
Getting CI back to green took quite a bit of effort -- not just in this PR, but also to update our CI images and system tests and whatnot. Great work @sarahchen6 @lloeki @anmarchenko ;) I'm going to go ahead and merge this one! |
What does this PR do?
Fixes previously failing test-memcheck job by using released Ruby version 3.4.1 instead of Ruby 3.4.0-preview
Motivation:
CI started to fail
Change log entry
none
How to test the change?
CI is green