Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-3328 report DI status in environment logger summary #4285

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Conversation

p-datadog
Copy link
Member

What does this PR do?

Adds the state of dynamic instrumentation to environment logger summary reporting.

Motivation:

For troubleshooting it would be helpful to see whether DI is effectively turned on (i.e. it's requested to be on programmatically or via an environment variable, and environmental conditions are appropriate (environment, Ruby version, etc.))

Change log entry

Yes: library will report whether dynamic instrumentation is enabled in startup summary report

Additional Notes:

How to test the change?

Unit tests are included

@p-datadog p-datadog requested a review from a team as a code owner January 13, 2025 21:42
@github-actions github-actions bot added the core Involves Datadog core libraries label Jan 13, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 13, 2025

Datadog Report

Branch report: di-status
Commit report: 22b8070
Test service: dd-trace-rb

✅ 0 Failed, 22197 Passed, 1476 Skipped, 5m 13.15s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2025

Benchmarks

Benchmark execution time: 2025-01-14 19:32:47

Comparing candidate commit 22b8070 in PR branch di-status with baseline commit 5235204 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Trace Context

  • 🟥 throughput [-4216.569op/s; -4113.986op/s] or [-11.004%; -10.736%]

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (5235204) to head (22b8070).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4285      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files        1354     1354              
  Lines       82410    82455      +45     
  Branches     4213     4216       +3     
==========================================
+ Hits        80538    80577      +39     
- Misses       1872     1878       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-datadog p-datadog merged commit 8f97fe7 into master Jan 14, 2025
378 checks passed
@p-datadog p-datadog deleted the di-status branch January 14, 2025 19:45
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants