Implement dup and O_TMPFILE #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlovich
force-pushed
the
file-dup
branch
3 times, most recently
from
6950712 to
f05630d
Compare
Make it possible to create an unnamed temporary file and to dup a DmaFile.
glommer
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to create an unnamed temporary file and to dup a DmaFile.
What does this PR do?
The file can be requested to be opened
O_TMPFILE(i.e. new unnamed file in a directory) andDmaFile::dupwill create a newDmaFilepointing to the exact same fd. This way we can create an unnamed file & create clones of it & (in the future) link it into the filesystem.Motivation
I need to create a temporary file. Also I need the same file opened twice as a workaround for #605.
Related issues
Additional Notes
Checklist
[X] I have added unit tests to the code I am submitting
[] My unit tests cover both failure and success scenarios
[] If applicable, I have discussed my architecture