Only log about broken instances if there are some (#280)

DataDog · May 15, 2020 · 8004234 · 8004234
1 parent 120e56a
commit 8004234
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/main/java/org/datadog/jmxfetch/App.java b/src/main/java/org/datadog/jmxfetch/App.java
@@ -557,9 +557,7 @@ public TaskStatusHandler invoke(
         }
 
         // Attempt to fix broken instances
-        log.debug("Trying to recover broken instances...");
         fixBrokenInstances(reporter);
-        log.debug("Done trying to recover broken instances.");
 
         try {
             appConfig.getStatus().flush();
@@ -569,6 +567,11 @@ public TaskStatusHandler invoke(
     }
 
     private void fixBrokenInstances(Reporter reporter) {
+        if (brokenInstanceMap.isEmpty()) {
+            return;
+        }
+
+        log.debug("Trying to recover broken instances...");
         List<InstanceTask<Void>> fixInstanceTasks =
                 new ArrayList<InstanceTask<Void>>(brokenInstanceMap.values().size());
 
@@ -629,6 +632,8 @@ public TaskStatusHandler invoke(
         } catch (Exception e) {
             // NADA
         }
+
+        log.debug("Done trying to recover broken instances.");
     }
 
     /**