Fixes divide by zero bug introduced in previous commit

DataDog · Dec 27, 2023 · ea0bf5b · ea0bf5b
1 parent c118cc2
commit ea0bf5b
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/main/java/org/datadog/jmxfetch/Instance.java b/src/main/java/org/datadog/jmxfetch/Instance.java
@@ -710,9 +710,6 @@ private synchronized int addMatchingAttributesForBean(
                             e);
                 }
             }
-            // TODO if there was a matching conf, then we must return
-            // true so that the instanceTelemetryBeanRatio can be kept correctly
-            // ref: jmxfetch pr 487
 
             if (jmxAttribute.getMatchingConf() == null
                     && (action.equals(AppConfig.ACTION_LIST_EVERYTHING)
@@ -763,7 +760,7 @@ private void getMatchingAttributes() throws IOException {
             }
         }
 
-        if (instanceTelemetryBean != null) {
+        if (instanceTelemetryBean != null && beans.size() > 0) {
             instanceTelemetryBean.setBeanMatchRatio(beansWithAttributeMatch / beans.size());
         }