Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix Dirty tag to build release workflow #2706

Merged
merged 1 commit into from
Nov 20, 2023
Merged

CI: Fix Dirty tag to build release workflow #2706

merged 1 commit into from
Nov 20, 2023

Conversation

sieniven
Copy link
Contributor

Summary

  • Dirty tag issue caused from upgrading github checkout action from v1 to v3, which causes the workflow to create a local working branch when checking out the reference tag
  • PR fixes the issue by explicitly specifying master branch ref on the checkout action, and upgrades the version from v3 to the latest v4.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit 5b0e006 into master Nov 20, 2023
@prasannavl prasannavl deleted the niven/ci-release branch November 20, 2023 09:03
@sieniven sieniven mentioned this pull request Nov 20, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo approved these changes

@Bushstar Bushstar Awaiting requested review from Bushstar Bushstar is a code owner

@prasannavl prasannavl Awaiting requested review from prasannavl prasannavl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sieniven @Jouzo @prasannavl