Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test to be compatible with latest Glamour v0.8.0 #235

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ottok
Copy link
Contributor

@ottok ottok commented Dec 28, 2024

Latest src:golang-github-charmbracelet-glamour 0.8.0-1 caused the tests
in dh-make-golang to fail to due slightly changed line wrapping. Fix
this by updating the tests to match the new expected output.

Also update the dependencies so that Glamour is v0.8.0 and everything else
has the bare minimal update as generated by go mod tidy.

Closes: Debian Bug#1091273

@ottok ottok force-pushed the fix-glamour-v0.8.0-compat branch 6 times, most recently from 3467624 to 1c3050d Compare December 29, 2024 01:37
@ottok ottok requested a review from anthonyfok December 29, 2024 01:38
@ottok
Copy link
Contributor Author

ottok commented Jan 7, 2025

Thanks @tianon and @zhsj for commenting my other PRs. Could you review/approve this one too? Thanks

Latest src:golang-github-charmbracelet-glamour 0.8.0-1 caused the tests
in dh-make-golang to fail to due slightly changed line wrapping. Fix
this by updating the tests to match the new expected output.

Also update the dependencies so that Glamour is v0.8.0 and everything else
has the bare minimal update as generated by `go mod tidy`.

Closes: Debian Bug#1091273
@ottok ottok force-pushed the fix-glamour-v0.8.0-compat branch from 1c3050d to 0846d5a Compare January 14, 2025 03:06
@ottok
Copy link
Contributor Author

ottok commented Jan 14, 2025

As this provably fixes a clear issue (Bug#1091273) and nobody has objected this in past two weeks, I am self-reviewing this now and merging unless I spot any issues with my own "fresh eyes".

@ottok ottok merged commit 0846d5a into Debian:master Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant