Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Salsa CI configuration #238

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Update Salsa CI configuration #238

merged 1 commit into from
Jan 14, 2025

Conversation

Maytha8
Copy link
Contributor

@Maytha8 Maytha8 commented Jan 5, 2025

This is the follow-up to the update of the authoritative copy in pkg-go-tools.

@ottok
Copy link
Contributor

ottok commented Jan 7, 2025

Nice! Looks good to me!

@ottok ottok assigned ottok and unassigned ottok Jan 7, 2025
@ottok ottok self-requested a review January 7, 2025 04:54
Copy link
Contributor

@ottok ottok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but then again I did the original version, so perhaps wait until some additional person also acks this :)

@ottok
Copy link
Contributor

ottok commented Jan 8, 2025

Just checking, are you sure this was the latest version from https://salsa.debian.org/go-team/infra/pkg-go-tools/? Didn't you want to have a fix for it first, and only then copy it to other places?

@Maytha8
Copy link
Contributor Author

Maytha8 commented Jan 8, 2025

No, LGTM.

This is the follow-up to the update of the authoritative copy in pkg-go-tools.
@ottok
Copy link
Contributor

ottok commented Jan 14, 2025

This has been open for over a week, and anyway it just implements the Salsa CI file that was already reviewed and approved for pkg-go-tools, so merging now.

@ottok ottok merged commit cdc1ff4 into Debian:master Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants