Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Significant changes ahead of release 0.2.0 #32

Merged
merged 60 commits into from
Nov 18, 2024
Merged

Significant changes ahead of release 0.2.0 #32

merged 60 commits into from
Nov 18, 2024

Conversation

francois-drielsma
Copy link
Contributor

Core changes:

  • Complete refactoring of flash matching to accommodate SBND
  • Complete refactoring of the Geometry class to support light detectors and CRTs
  • Complete clean-up of build, post and ana to get rid of mutable defaults/class-wide attributes
  • Addition of new *Particle attributes
  • Addition of shower post-processors to deal with common failure modes
  • Addition of a true lite option in the post-processor to make extremely lite files (0.2 MB/event in ICARUS)

Bear Carlson and others added 30 commits September 19, 2024 10:13
Make flash matching compatible with SBND's semi-analytical model and …
0dde1df 
…opaque cathode
@bear-is-asleep
Remove print statements
33c534b
@bear-is-asleep
Remove print statements
2f07565
Temporary fix for variable length flash attributes to be compatible w…
435195b 
…ith loggers
Bug fix for flash matched flag. Also included calibrations for light …
9efb393 
…path
Merge branch 'develop' of https://github.com/DeepLearnPhysics/spine i…
a77a927 
…nto develop
@francois-drielsma
Add vertex point parser to be used to upweight semantic segmentation …
8c435db 
…loss
@francois-drielsma
Merge branch 'develop' of https://github.com/francois-drielsma/spine …
43b874e 
…into develop
Merge branch 'develop' of https://github.com/francois-drielsma/spine …
b1009d5 
…into develop
Added shower startpoint corrector and additional reco_particle attrib…
6f36082 
…utes for adjusting nue cut parameters
Fix legacy naming mistakes and added type-setting to dataclass attrib…
cb79d6d 
…utes
Change shower multi-arm check to have parameter in degrees
b43a965
Typo in vertex_distance attribute assignment
bf52aa0
@francois-drielsma
Merge pull request #6 from dkoh0207/develop
95ce26a 
Added shower startpoint correction post-processor and reco particle attributes
@francois-drielsma
First pass at vertex neighbor upweighting in uresnet
83a5e1a
@francois-drielsma
Fix deprecated syntax
c0b8a36
@francois-drielsma
Fixed bug when not providing weights to UResNet
fb291d6
@francois-drielsma
Fixed barycenter flash matching post-processor
52834bc
@francois-drielsma
Skip emptry logs when making training curves
54bcd78
@francois-drielsma
File sanity check script typo fix
73dddd6
@francois-drielsma
Bug fix in limit_num_files
2f33926
@francois-drielsma
Remove redundant check on limit_num_files
e36cba3
@francois-drielsma
Add attribute to optical data product to store the optical volume ID
a0c2db5
@francois-drielsma
Make the Driver an iterator to simplify for loops.
682afec
@francois-drielsma
Complete refactoring of the geometry storage/parsing/objects
24ee7f2
@francois-drielsma
Bug fixes, now runs with new geometry (more tests to do)
38ae298
@francois-drielsma
Merge branch 'develop' into feature/bearc_sbnd_fmatch
98a5237
@francois-drielsma
Fixed cathode crossing post-proc + other minor bugs
5380b39
@francois-drielsma
Fix end-points of cathode crossers for particles that were merged ups…
29c83e1 
…tream
@francois-drielsma
Merge pull request #4 from bear-is-asleep/feature/bearc_sbnd_fmatch
ed575f6 
Make flash matching compatible with SBND
francois-drielsma and others added 29 commits November 10, 2024 23:40
@francois-drielsma
File missing from previous commit (need -f)
96c48b3
@francois-drielsma
Change default colorscale of flashes in main Drawer
e1781a6
@francois-drielsma
Prevent configuration to be modified in place (preserved it in the wr…
13940d0 
…iter)
@francois-drielsma
Allow to specify overwrite in ana scripts at the top level or in spec…
f73bdd4 
…ific modules
@francois-drielsma
Add option to use legacy OpT0Finder
7a760f8
@francois-drielsma
Add flash_volume_ids attribute to interaction objects
a0323d9
@zhulcher
Update particle.py
ea4f182
@zhulcher
Merge branch 'francois-drielsma:develop' into develop
9cd7f4f
@francois-drielsma
Added option to store CSDA/MCS KE for all PID hypotheses
4adc9a0
@francois-drielsma
Bug fix when using full detector boundaries for containment
22a634f
@francois-drielsma
Typo fix in flash matcher post-proc
3143d3e
@francois-drielsma
Use optical channelt to detector mapping in drawer
e397f6e
@francois-drielsma
Fix flash matching drawing for SBND
b4c23a3
@francois-drielsma
Bad default flash PE per channel values
686146e
@francois-drielsma
Merge pull request #7 from zhulcher/develop
92c9d8f 
Add reco quantities to truth and reco particles
@francois-drielsma
Add distance_travel attribute to the Neutrino dataclass
0caea95
@francois-drielsma
Add a couple more reconstructed quantities to the RecoParticle class
b8e5b62
@francois-drielsma
Add option in writer to make truly lite files
642468b
@francois-drielsma
Nomenclature change
8fa5452
@francois-drielsma
Simple bug fix with optical detector index
1cf9286
@francois-drielsma
Get rid of mutable class attributes in dataclasses
df8484d
@francois-drielsma
Removed all mutable class attributes from the builders
ddd07a8
@francois-drielsma
Fix bug with scalar_dict casting, get rid of binarization
4ddcf57
@francois-drielsma
Make sure calibration is also applied to interaction objects in the p…
072f684 
…ost-proc
@francois-drielsma
Add option to store variable-length arrays to CSV by providing a leng…
354a6c9 
…th to cast them to
@francois-drielsma
Removed all traces of mutable defaults/class attributes from post module
2bc833f
@francois-drielsma
More clean up of mutable class attributes
dc04298
@francois-drielsma
Removed all traces of mutable defaults/class attributes from ana module
eeb2f64
@francois-drielsma
Make flash parser LArCV version agnostic
d09435b
@francois-drielsma francois-drielsma merged commit 84a81ce into DeepLearnPhysics:develop Nov 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francois-drielsma @bear-is-asleep @zhulcher