-
Notifications
You must be signed in to change notification settings - Fork 81
13th August 2020
Presentation: N/A
Chair: Yunguan
Minutes: Nina Montana Brown
Attendance:
Yunguan Fu YF
Ester Bonmati EB
Zac Baum ZB
Shaheer Saeed SS
Adria Casamitjana AC
Nina Montana Brown NMB
Apologies:
Yipeng Hu
Qianye Yang QY
Matt Clarkson MC
Alex Grimwood AG
Zhe Min ZM
Remi Delaunay RD
Who? | Discussion Points | Next |
---|---|---|
Zac Baum | ||
Ester Bonmati | Finish demo and merge to master | |
Adria Casamitjana | ||
Matt Clarkson | ||
Remi Delaunay | ||
Yunguan Fu | Test is nearly perfect, maybe some tests need to be improved. This week all bugs should be fixed, then it is important to recheck all the demos, as some major changes have happened (data loader, prediction output, saving in nifti1 format) | Improve docs Automate demo test |
Alex Grimwood | Happy to begin revising docs, will raise/assign issues over the next week | |
Yipeng Hu | The joss paper review takes at most a few weeks. In order to get this ready before miccai, so, the “DeepReg-beta will be released in Autumn 2020”. Demo are almost all ready (ester is the last planned “almost there”) Please demo-makers and others all check the requirement again (now in doc) and raise issues - you can group them to demo_paired_mrus_prostate issues if easier to address in one go. Consider change the demo authors to DeepReg Core Dev Team, with a corresponding author info;. Ideally we need one more demo for grouped loader, cardio application if possible - any ideas/suggestions? open data set is the key. Should we clean up the dependencies? Separate dev and user installation - edu-challenge had quite a few conflicts with modern “data science” packages - most, if not all are coming from testing/doc; Feedback on doc, is it clear and how to improve. (Zac, Alex, Matt) Suggest to have a meeting next week as it is close to R1 Pypi package anyone? | Use excel to get the availability of dev team |
Nina Montana Brown | Sphinx docs Pypi Release | |
Saeed Shaheer | Upload final ckpts for two demos | |
Qianye Yang | ||
Zhe Min |
YF:
-
Thanks all for contributing to tests!
-
Data loader tests need to be improved - Yunguan to raise tickets about things he considers are missing. Good to do this before release.
-
This week - resolving bugs and seem to be compatible with demos.
-
Next week: improve docs and demos.
-
Automate demo testing (not to be included in CI) - how to guarantee backwards compatibility with changes in repo? A script to run.
YH (NMB discusses):
-
Review docs, demos: raise tickets for cross review.
-
PYPI: Zac + Nina to investigate how.
SS:
- Nothing to discuss: demos added, ckpts to be added to model zoo this week.
YF:
- Meeting next week to wrap up pre R1.
tables: for google docs --> markdown, use tablesgenerator.org
formatting: for google docs --> markdown, use stackedit