Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_typed_array #415

Merged
merged 18 commits into from
Jan 22, 2025
Merged

Fix is_typed_array #415

merged 18 commits into from
Jan 22, 2025

Conversation

richarddd
Copy link
Contributor

@richarddd richarddd commented Jan 21, 2025

The current implementation panics if object is not a typed array due to bad unwrap. This PR fixes that.
Also fixes #416

@richarddd
Copy link
Contributor Author

@DelSkayn please have a look. I had to bump MSRV to 1.77 because some features requires minimum 1.77. Also bindings generate bool on some platforms and i32 on others, hence the required casting.

@DelSkayn
Copy link
Owner

Weird that the MSRV didn't fail before. If offset_of was introduced in 1.77 it shouldn't have compiled on 1.65..

.gitignore Show resolved Hide resolved
@richarddd
Copy link
Contributor Author

Weird that the MSRV didn't fail before. If offset_of was introduced in 1.77 it shouldn't have compiled on 1.65..

I didn't fail because that code was feature gated

I would like to avoid committing the lock file. I think it is still best to ensure rquickjs is tested against the latest dependencies if possible. The linked blog post says that they do not have a default recommendation not that they recommend against not committing the lockfile.

No problem, but then MSRV needs to be bumped to 1.81 due to home dependency:
https://crates.io/crates/home/versions
https://github.com/DelSkayn/rquickjs/actions/runs/12889992657/job/35938535528

@DelSkayn DelSkayn enabled auto-merge January 22, 2025 16:54
Copy link
Owner

@DelSkayn DelSkayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DelSkayn DelSkayn merged commit acab22e into DelSkayn:master Jan 22, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSRV is broken due to home crate
3 participants