-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix is_typed_array #415
Fix is_typed_array #415
Conversation
@DelSkayn please have a look. I had to bump MSRV to 1.77 because some features requires minimum 1.77. Also bindings generate |
Weird that the MSRV didn't fail before. If offset_of was introduced in 1.77 it shouldn't have compiled on 1.65.. |
15ad820
to
80d7a90
Compare
I didn't fail because that code was feature gated
No problem, but then MSRV needs to be bumped to 1.81 due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The current implementation panics if object is not a typed array due to bad unwrap. This PR fixes that.
Also fixes #416