Ushanka Trinket Addition - Branch #2849
Open
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update the trinkets.yml list for character's loadouts. Adds the Ushanka to the possible trinkets list, for more variation on roundstart, While also setting a precedent that hats can be a potential trinket, which will hopefully lead to yet more variety, and hopefully an incentive for more people to add hats. Signed-off-by: PathOwOgen <[email protected]>
Capitalization Signed-off-by: PathOwOgen <[email protected]>
…ions Signed-off-by: PathOwOgen <[email protected]>
github-actions
bot
added
size/XS
deltanedas
requested changes
Feb 2, 2025
Comment on lines
+373
to
+377
| - type: loadout | ||
| id: Ushanka | ||
| storage: | ||
| back: | ||
| - Ushanka |
There was a problem hiding this comment.
wrong indentation + move this into the file under _DV
Lyndomen
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This is a PR in order to add the Ushanka (ClothingHeadHatUshanka) to the Trinkets list for characters.
This is an updated version of a Pull Request added and rejected moments ago on a separate branch from Master named Ushanka-Trinket, and master should be rebased back to original In order to fix the Contribution Guidelines error
Why / Balance
I believe specialty hats is a lovely thing for Trinkets, and currently AFAIK, Ushankas are unable to be ordered or made. but rather simple found around places like Maints. With Ushankas (and potentially more hats later) added to the Trinkets list, this item will be much more likely to be used, and adds more variety to the choices in Trinkets. As for Balance, Ushankas are purely a cosmetic for characters so I do not think there is any concerns for balance, other than the rarity of Ushankas being found in vents being suppressed.
Technical details
I have added the Ushanka to the Loadouts/Trinkets list as it's own category marked with # hats , the Loadout Groups under the trinkets group. During testing I found that in the process of adding these that additions somehow removed almost all of the trinkets from the available list in loadouts. I have tried shuffling around the spacing and indentation, as well as checking the ID to see if its something in my additions, but I have not been able to sniff out the thing I wrote which screwed everything up, and the Ushanka is also missing from the list and I would love help with figuring out what happened.
A second issue I have encountered while I am reviewing this Pull Request is that on my laptop the game now Crashes upon opening the Loadouts screen.
The commits list is a little long as I was trying shuffling things around and trying to edit any typos I have made.
All of this to say, DO NOT MERGE THIS PULL REQUEST UNTIL FIXED
Media
Requirements
DO NOT MERGE THIS PULL REQUEST UNTIL FIXED
Breaking changes
I have attempted to follow the example of other additions to the trinkets list, though I have found issues with the implementation, and at this time I do not have instructions on how to resolve them, as I need to find how to resolve the issues currently before predicting how the finished change will impact other things.
Changelog
🆑 - add: Added Ushankas to the Trinkets list, allowing characters to take a Ushanka as a Round Start item.