Added bags for HoP #2856

Possumongus · 2025-02-02T16:04:56Z

About the PR

I've decided to add specific clothing to the HoP, mainly bags. I'm planning on also doing this for DeltaV specific roles, but I figured this would be a start
They are available in the loadout screen, and you can put em on at the start of the game

Why / Balance

I felt that command shouldn't be wearing gray bags, one is for style reasons. It breaks up the visual consistency of the character and undermines certain command roles to feel less important. I also feel its vital that command roles have easy to distinguish bags. It lets security know when someone has something they shouldn't, and it paints a big X for the antags to go after.

About the sprites themselves, I've tried to breakup the shape a little bit while still keeping it recognizable, I've tested the sprites in B/W etc to make sure they are visually distinguishable from other bags. I've added small extra bags, changed the shape in general just to make it more visually distinct. I might update the sprites and any and all feedback is well appreciated.

Technical details

Changed the load-out group of the HoP in the main prototype file, added comments to keep it easy to see what I changed. Rest is just adding the items themselves and the associated files to make the sprites work.

Media

Media attached

Requirements

[ X ] I have tested all added content and changes.
[ X ] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

only changed 1 baseline file which was the load-out group for HoP's backpacks. Commented original bags for easily delete and fix in case they need to changed
Changelog

🆑

add: Added new HoP backpacks to keep visual consistency!
remove: Removed default bags from the hop loadout

github-actions · 2025-02-02T16:05:35Z

RSI Diff Bot; head commit dbe1c88 merging into 4a6ff66
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Clothing/Back/Backpacks/hop.rsi

State	Old	New	Status
equipped-BACKPACK			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_DV/Clothing/Back/Duffels/hop.rsi

State	Old	New	Status
equipped-BACKPACK			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_DV/Clothing/Back/Satchels/hop.rsi

State	Old	New	Status
equipped-BACKPACK			Added
icon			Added
inhand-left			Added
inhand-right			Added

Edit: diff updated after dbe1c88

Radezolid

All the JSON needs proper indentation (4 spaces instead of 2), for an example check this one:

Delta-v/Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/security_alt.rsi/meta.json

Lines 1 to 30 in 47749d9

    
           { 
        
               "version": 1, 
        
               "license": "CC0-1.0", 
        
               "copyright": "Original work by TJohnson.", 
        
               "size": { 
        
                   "x": 32, 
        
                   "y": 32 
        
               }, 
        
               "states": [ 
        
                   { 
        
                       "name": "icon" 
        
                   }, 
        
                   { 
        
                       "name": "equipped-INNERCLOTHING", 
        
                       "directions": 4 
        
                   }, 
        
                   { 
        
                       "name": "inhand-left", 
        
                       "directions": 4 
        
                   }, 
        
                   { 
        
                       "name": "inhand-right", 
        
                       "directions": 4 
        
                   }, 
        
                   { 
        
                       "name": "rolled-equipped-INNERCLOTHING", 
        
                       "directions": 4 
        
                   } 
        
               ] 
        
           }

Radezolid · 2025-02-02T16:23:06Z

Resources/Prototypes/_DV/Entities/Clothing/Back/backpacks.yml

@@ -0,0 +1,33 @@
+- type: entity
+  parent: [Clothing, ContentsExplosionResistanceBase]


Inherit from ClothingBackpack

Radezolid · 2025-02-02T16:23:51Z

Resources/Prototypes/_DV/Entities/Clothing/Back/backpacks.yml

+  - type: Item
+    size: Huge
+  - type: Clothing
+    quickEquip: false
+    slots:
+    - back
+  - type: Storage
+    grid:
+    - 0,0,6,3
+    maxItemSize: Huge
+  - type: ContainerContainer
+    containers:
+      storagebase: !type:Container
+        ents: []
+  - type: UserInterface
+    interfaces:
+      enum.StorageUiKey.Key:
+        type: StorageBoundUserInterface
+  # to prevent bag open/honk spam
+  - type: UseDelay
+    delay: 0.5
+  - type: ExplosionResistance
+    damageCoefficient: 0.9


Delete once you do the correct inheritance.

Radezolid · 2025-02-02T16:25:27Z

Resources/Prototypes/_DV/Entities/Clothing/Back/duffel.yml

@@ -0,0 +1,16 @@
+- type: entity
+  parent: ClothingBackpack


Inherit from ClothingBackpackDuffel.

Radezolid · 2025-02-02T16:25:55Z

Resources/Prototypes/_DV/Entities/Clothing/Back/duffel.yml

+  - type: Storage
+    maxItemSize: Huge
+    grid:
+    - 0,0,7,4
+  - type: ClothingSpeedModifier
+    walkModifier: 1
+    sprintModifier: 0.9
+  - type: HeldSpeedModifier


Delete once the correct prototype is inherited.

Radezolid · 2025-02-02T16:26:20Z

Resources/Prototypes/_DV/Entities/Clothing/Back/satchel.yml

@@ -0,0 +1,13 @@
+- type: entity
+  parent: ClothingBackpack


Inherit from ClothingBackpackSatchel

Radezolid · 2025-02-02T16:26:35Z

Resources/Prototypes/_DV/Entities/Clothing/Back/satchel.yml

+  - type: Storage
+    grid:
+    - 0,0,1,3
+    - 3,0,6,3
+    - 8,0,9,3


Delete once the correct protoype is inherited.

Radezolid · 2025-02-02T16:27:09Z

Resources/Prototypes/_DV/Loadouts/loadout_groups.yml

+

Radezolid · 2025-02-02T16:28:35Z

Resources/Textures/_DV/Clothing/Back/Backpacks/hop.rsi/meta.json

Needs proper indentation of four spaces instead of two.

Radezolid · 2025-02-02T16:28:46Z

Resources/Textures/_DV/Clothing/Back/Duffels/hop.rsi/meta.json

Needs proper indentation of four spaces instead of two.

Radezolid · 2025-02-02T16:28:51Z

Resources/Textures/_DV/Clothing/Back/Satchels/hop.rsi/meta.json

Needs proper indentation of four spaces instead of two.

Radezolid

Forgot to mention these.

Radezolid · 2025-02-02T16:32:18Z

Resources/Prototypes/Loadouts/loadout_groups.yml

+ ## - CommonBackpack
+ ## - CommonSatchel
+ ## - CommonDuffel


Forgot to mention, these should be properly commented out, remove one character of these two ##

Radezolid · 2025-02-02T16:32:53Z

Resources/Prototypes/Loadouts/loadout_groups.yml

+ ## - CommonBackpack
+ ## - CommonSatchel
+ ## - CommonDuffel
+  - BackpackHoP #DELTA V
+  - SatchelHoP #DELTA V
+  - HopDuffel #DELTA V


All of this should be enclosed in a multi line DeltaV comment, like this:

# Start DeltaV changes blah blah # End of DeltaV changes

Fixed, I think

ThataKat · 2025-02-02T16:49:53Z

Under direction review, get back to you in a day or so

Fixed issues

Possumongus · 2025-02-02T18:14:37Z

All the JSON needs proper indentation (4 spaces instead of 2), for an example check this one:

Delta-v/Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/security_alt.rsi/meta.json

Lines 1 to 30 in 47749d9

{

"version": 1,

"license": "CC0-1.0",

"copyright": "Original work by TJohnson.",

"size": {

"x": 32,

"y": 32

},

"states": [

{

"name": "icon"

},

{

"name": "equipped-INNERCLOTHING",

"directions": 4

},

{

"name": "inhand-left",

"directions": 4

},

{

"name": "inhand-right",

"directions": 4

},

{

"name": "rolled-equipped-INNERCLOTHING",

"directions": 4

}

]

}

changes done!

Radezolid · 2025-02-02T19:19:05Z

Resources/Prototypes/Loadouts/loadout_groups.yml

+ # - CommonBackpack
+ # - CommonSatchel
+ # - CommonDuffel
+ # Start DeltaV changes


This should start before the line 181

Radezolid · 2025-02-02T19:19:51Z

Resources/Prototypes/_DV/Loadouts/Jobs/Command/head_of_personnel.yml

@@ -24,6 +24,22 @@
  id: HoPBoatswain
  equipment:
    jumpsuit: ClothingUniformJumpsuitBoatswain
+


Remove these four spaces

Radezolid · 2025-02-02T19:21:36Z

Resources/Textures/_DV/Clothing/Back/Backpacks/hop.rsi/meta.json

The whole file is over indented by 1 space.

Radezolid · 2025-02-02T19:25:13Z

Resources/Textures/_DV/Clothing/Back/Backpacks/hop.rsi/meta.json

+         "size": {
+             "x": 32,
+             "y": 32


This is over indented by a total of 5 spaces, size should be at the same height that copyright, remove the space I pointed out at the file comment and then fix the indentation.

Radezolid · 2025-02-02T19:26:21Z

Resources/Textures/_DV/Clothing/Back/Duffels/hop.rsi/meta.json

This file is overindented by one space.

Radezolid · 2025-02-02T19:26:41Z

Resources/Textures/_DV/Clothing/Back/Satchels/hop.rsi/meta.json

JSON over indented by one space.

mogus

bc33b16

Possumongus requested review from a team as code owners February 2, 2025 16:04

github-actions bot added S: Needs Review size/M 64-255 lines Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi and removed size/M 64-255 lines labels Feb 2, 2025

Merge branch 'master' into Added-HoP-bags-possum

83af620

github-actions bot added the size/M 64-255 lines label Feb 2, 2025

Possumongus changed the title ~~mogus~~ Added bags for HoP Feb 2, 2025

Radezolid suggested changes Feb 2, 2025

View reviewed changes

Fixed issues

9d6e44a

Lyndomen previously approved these changes Feb 2, 2025

View reviewed changes

Merge pull request #1 from Possumongus/master

dbe1c88

Fixed issues

Possumongus dismissed Lyndomen’s stale review via dbe1c88 February 2, 2025 18:09

Possumongus requested a review from Radezolid February 2, 2025 18:14

Radezolid suggested changes Feb 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added bags for HoP #2856

Added bags for HoP #2856

Possumongus commented Feb 2, 2025

github-actions bot commented Feb 2, 2025 •

edited

Loading

Radezolid left a comment

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid left a comment

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Possumongus Feb 2, 2025

ThataKat commented Feb 2, 2025

Possumongus commented Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

Radezolid Feb 2, 2025

	{
	"version": 1,
	"license": "CC0-1.0",
	"copyright": "Original work by TJohnson.",
	"size": {
	"x": 32,
	"y": 32
	},
	"states": [
	{
	"name": "icon"
	},
	{
	"name": "equipped-INNERCLOTHING",
	"directions": 4
	},
	{
	"name": "inhand-left",
	"directions": 4
	},
	{
	"name": "inhand-right",
	"directions": 4
	},
	{
	"name": "rolled-equipped-INNERCLOTHING",
	"directions": 4
	}
	]
	}

		@@ -0,0 +1,33 @@
		- type: entity
		parent: [Clothing, ContentsExplosionResistanceBase]

Added bags for HoP #2856

Are you sure you want to change the base?

Added bags for HoP #2856

Conversation

Possumongus commented Feb 2, 2025

About the PR

Why / Balance

Technical details

Media

Requirements

Breaking changes

github-actions bot commented Feb 2, 2025 • edited Loading

Radezolid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Radezolid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThataKat commented Feb 2, 2025

Possumongus commented Feb 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 2, 2025 •

edited

Loading