Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Streamer lawset #2866

Conversation

sowelipililimute
Copy link
Contributor

About the PR

This PR adds the Streamer lawset, based on how internet streamers communicate with their audiences.

Why / Balance

I've had the chance to play with these laws whenever I had no laws as a silicon (most notably during the recent silicon law outage), and they are a huge crowdpleaser. They encourage silicons to interact with a station in a way not covered by other lawsets, and players seem to quickly recognise the bit and go along with it, asking to be promoted to "Mod" and "gifting subscriptions" and whatnot. It turns what can be a distant character into one that's interacting with the station's crew at large a lot.

Technical details

  • add laws
  • add lawset
  • add lawset to ion storm chances
  • add lawset to roundstart chances

Media

grafik

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog
🆑

  • add: The Streamer lawset now exists for silicons, transforming them into Nanotrasen's funniest content creators

@sowelipililimute sowelipililimute requested review from a team as code owners February 3, 2025 17:25
@github-actions github-actions bot added S: Needs Review size/S 16-63 lines Changes: YML Changes any yml files Changes: Localization Changes any ftl files and removed S: Needs Review size/S 16-63 lines labels Feb 3, 2025
@Lyndomen
Copy link
Contributor

Lyndomen commented Feb 3, 2025

ok direction review 24 hours

Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ask you to fix the order of the parent and ID but I'll just do it for the whole file later.

@dvir001
Copy link
Contributor

dvir001 commented Feb 4, 2025

@deltanedas
Copy link
Member

24 hours
3 days ago

@Lyndomen
Copy link
Contributor

Lyndomen commented Feb 6, 2025

24 hours
3 days ago

:trollface:

Lyndomen
Lyndomen previously approved these changes Feb 6, 2025
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're pretty nervous about this one, but approved. If changes become necessary down the line, what we're thinking of adopting is less of a Chat centric rule, and more of an "Audience/Broadcaster" rule. But we will see how this one goes first!

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/S 16-63 lines and removed S: Merge Conflict Fix your PR! labels Feb 6, 2025
@deltanedas deltanedas enabled auto-merge (squash) February 6, 2025 20:01
@deltanedas deltanedas merged commit 3491782 into DeltaV-Station:master Feb 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants