Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ipc nukies not getting comms #2884

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

deltanedas
Copy link
Member

About the PR

estacao pirata shitcode my beloved

Why / Balance

fix

Technical details

  • moved to shared, _DV
  • fully refactored to be less shitty, using proxy instead of entity manager arg
  • Del instead of QueueDel so the headset doesn't exist for 1 tick

Media

normal ipcs still work + nukie ipcs now work
07:30:47

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

moved InternalEncryptionKeySpawner from _EE to _DV and removed EntityManager parameter

Changelog
🆑

  • fix: Fixed IPC nukies not getting comms.

@deltanedas deltanedas requested a review from a team as a code owner February 4, 2025 19:35
Copy link
Contributor

github-actions bot commented Feb 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added S: Merge Conflict Fix your PR! Changes: C# Changes any cs files and removed S: Merge Conflict Fix your PR! labels Feb 4, 2025
@Radezolid
Copy link
Contributor

Best review i can give you: "Tested in game, it worked even for LPOs and ninjas"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants