-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-sitter 0.24 upgrade #283
Conversation
@mwhitworth can you rebase Once this lands I would make a new release. |
f47ee20
to
4ef99b8
Compare
I'm rebasing this now (and checking the diff) I came across a message while cloning the repository, and some odd behaviour around
It might be clearest to fix this separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you make these two changes?
Then I'll finalize this branch for merge. |
4ef99b8
to
684c198
Compare
With this rebase and some further |
Thanks @mwhitworth for the effort! |
needs #279
changes required to upgrade to tree-sitter 0.24. But it looks like there is at least one issue with a 0.24 upgrade (#282), and upgrading to 0.23 has the advantage of moving Rust bindings to
tree-sitter-language
and simplifying further upgrades there.