Increase performance of AccumulateClues by preallocating and utilizin…

…g try_emplace
Desbordante · Oct 5, 2024 · 3b2b34f · 3b2b34f
1 parent fccf6ae
commit 3b2b34f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/core/algorithms/dc/FastADC/util/clue_set_builder.h b/src/core/algorithms/dc/FastADC/util/clue_set_builder.h
@@ -24,7 +24,10 @@ inline ClueSet BuildClueSet(std::vector<PliShard> const& pliShards, PredicatePac
             }
 
             for (auto const& [clue, count] : partial_clue_set) {
-                clue_set[clue] += count;
+                auto [it, inserted] = clue_set.try_emplace(clue, count);
+                if (!inserted) {
+                    it->second += count;
+                }
             }
         }
     }

diff --git a/src/core/algorithms/dc/FastADC/util/common_clue_set_builder.h b/src/core/algorithms/dc/FastADC/util/common_clue_set_builder.h
@@ -35,12 +35,15 @@ ClueSet AccumulateClues(Vectors const&... vectors) {
     ClueSet clue_set;
     int64_t clue_zero_count = 0;
 
+    clue_set.reserve((vectors.size() + ...));
+
     auto insert_clues = [&](std::vector<Clue> const& clues) {
         for (auto const& clue : clues) {
             if (clue.none()) {
                 ++clue_zero_count;
             } else {
-                clue_set[clue]++;
+                auto [it, inserted] = clue_set.try_emplace(clue, 1);
+                if (!inserted) it->second++;
             }
         }
     };