-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement set based aod verifier, support aod mining in fastod #468
Open
polyntsov
wants to merge
25
commits into
Desbordante:main
Choose a base branch
from
polyntsov:aod
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4267c23
Add ColumnIndexOption and move there ValidateIndex
polyntsov 31f3c47
Add parameter to allow empty list of indices in IndicesOption
polyntsov 1e76762
Move complex stripeed partition swap and create definitions to cpp
polyntsov 20592c8
Refactor Swap in complex stripped partition
polyntsov 4d65979
Introduce od::Ordering enum and use it instead of bool Ascending
polyntsov f043b22
Introduce partition type for complex stripped partition as create param
polyntsov b452c28
Accept in CreateAttributeSet any range as list of attributes
polyntsov 789c617
Store DataFrame in ComplexStrippedPartition as raw pointer
polyntsov 0214e5d
Store DataFrame directly as value in Fastod
polyntsov eef5077
Move nd_verifier's VectorToString to general util and accept any range
polyntsov 7cff09d
Add missing <vector> include to config/iption.h
polyntsov cae91d2
Add method to convert fastod::AttributeSet to vector of column indices
polyntsov 187a778
Add a callback to Option which is called before the option is set
polyntsov 1f901a6
Implement getters for context and cols in canonical ods
polyntsov cdb4980
Implement a function to load algo data without configuring execute opts
polyntsov 8b24e2f
Introduce is required callback to option
polyntsov d938c38
Allow absence of non-required options in algo factory
polyntsov fa7af04
Implement aod verifier and cover it with tests
polyntsov 7d04aea
Implement python bindings to set based aod verifier
polyntsov 60c2927
Implement error parameter for fastod and add tests for aod mining
polyntsov df33951
Specify in readme that we now support approximate set-based ODs
polyntsov 4c350d0
Implement aod verification python example
polyntsov 56a0f31
Avoid unnecessary copying of partitions in fastod partition cache
polyntsov a0e7af5
Don't store indices vectors via shared ptr in fastod complex partition
polyntsov 3f6ec49
Fallback to split and swap validation when error is zero in canonical od
polyntsov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
A commit description explaining why will come in handy |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, some commit description will be nice