Code

FastADC implementation#470

Code

Open

ol-imorozko wants to merge 86 commits intoDesbordante:mainDesbordante/desbordante-core:mainfrom ol-imorozko:FastADCol-imorozko/Desbordante:FastADCCopy head branch name to clipboard

+5,085-10

Commits

Commits on Jan 13, 2025

• Replace int with int64_t in Predicate class

  Show description for 451c76f
  ol-imorozko

  committed
  451c76f

  Copy full SHA for 451c76f

• Initial commit that adds dc folder and placeholder for dc.h

  Show description for 82f8437
  ol-imorozko

  committed
  82f8437

  Copy full SHA for 82f8437

• Implement method to get value from TypedColumnData

  ol-imorozko

  committed
  3c50e82

  Copy full SHA for 3c50e82

• Implement IndexProvider class

  Show description for 66c13dd
  ol-imorozko

  committed
  66c13dd

  Copy full SHA for 66c13dd

• Implement functions to get similarities metrics between two columns

  Show description for f348335
  ol-imorozko

  committed
  f348335

  Copy full SHA for f348335

• Implement PrediateBuilder class

  Show description for 9e057cf
  ol-imorozko

  committed
  9e057cf

  Copy full SHA for 9e057cf

• Implement tests for predicate space building

  Show description for fd64797
  ol-imorozko

  committed
  fd64797

  Copy full SHA for fd64797

• Implement Pli and PliShardBuilder

  Show description for e6d2fc3
  ol-imorozko

  committed
  e6d2fc3

  Copy full SHA for e6d2fc3

• Implement CommonClueSetBuilder

  Show description for 7753aed
  ol-imorozko

  committed
  7753aed

  Copy full SHA for 7753aed

• Implement SingleClueSetBuilder

  Show description for effa8ba
  ol-imorozko

  committed
  effa8ba

  Copy full SHA for effa8ba

• Implement CrossClueSetBuilder

  Show description for c99e02c
  ol-imorozko

  committed
  c99e02c

  Copy full SHA for c99e02c

• Add test that checks static fields of CommonClueSetBuilder

  Show description for 623ab63
  ol-imorozko

  committed
  623ab63

  Copy full SHA for 623ab63

• Implement ClueSetBuilder

  Show description for 7245877
  ol-imorozko

  committed
  7245877

  Copy full SHA for 7245877

• Add test that checks ClueSet building

  Show description for eded4d8
  ol-imorozko

  committed
  eded4d8

  Copy full SHA for eded4d8

• Add an ability to force kString type on TypedColumnData instead of kMixed

  ol-imorozko

  committed
  e1ed44c

  Copy full SHA for e1ed44c

• Add initial EvidenceSetBuilder class that builds cardinality mask

  Show description for 8d5edc1
  ol-imorozko

  committed
  8d5edc1

  Copy full SHA for 8d5edc1

• Add test that verifies CardinalityMask

  ol-imorozko

  committed
  3943406

  Copy full SHA for 3943406

• Implement Evidence

  Show description for fbb6a86
  ol-imorozko

  committed
  fbb6a86

  Copy full SHA for fbb6a86

• Implement EvidenceSet

  Show description for fc63418
  ol-imorozko

  committed
  fc63418

  Copy full SHA for fc63418

• Implement EvidenceSetBuilder

  Show description for 37e1136
  ol-imorozko

  committed
  37e1136

  Copy full SHA for 37e1136

• Add test to verify evidence set

  ol-imorozko

  committed
  68b990b

  Copy full SHA for 68b990b

• Fix wrong creating of inverted predicate, operands were swapped

  ol-imorozko

  committed
  1a4a57c

  Copy full SHA for 1a4a57c

• Add type alias for bitset holding predicates

  Show description for dee8405
  ol-imorozko

  committed
  dee8405

  Copy full SHA for dee8405

• Implement PredicateOrganizer class

  Show description for 4decf6e
  ol-imorozko

  committed
  4decf6e

  Copy full SHA for 4decf6e

• Add test that validates predicate organizer

  ol-imorozko

  committed
  e200ba1

  Copy full SHA for e200ba1

• Implement DCCandidateTrie class

  ol-imorozko

  committed
  495ae73

  Copy full SHA for 495ae73

• Implement PredicateSet class

  ol-imorozko

  committed
  e9c9528

  Copy full SHA for e9c9528

• Implement DenialConstraint class

  ol-imorozko

  committed
  148e24c

  Copy full SHA for 148e24c

• Return reference from GetImplications Predicate method

  ol-imorozko

  committed
  570c804

  Copy full SHA for 570c804

• Implement Closure class

  ol-imorozko

  committed
  3d05336

  Copy full SHA for 3d05336

• Implement NTreeSearch class

  Show description for e1f6f38
  ol-imorozko

  committed
  e1f6f38

  Copy full SHA for e1f6f38

• Implement DenialConstraintSet

  ol-imorozko

  committed
  e3804a8

  Copy full SHA for e3804a8

• Implement ApproximateEvidenceInverter class

  ol-imorozko

  committed
  860fafd

  Copy full SHA for 860fafd

• Implement test for approximate denial constraints

  ol-imorozko

  committed
  0409803

  Copy full SHA for 0409803

• Change namespace model to namespace algos::fastadc for FastADC files

  Show description for eca4790
  ol-imorozko

  committed
  eca4790

  Copy full SHA for eca4790

• Split FastADC files into subfolders

  Show description for f774cc2
  ol-imorozko

  committed
  f774cc2

  Copy full SHA for f774cc2

• Correct includes paths after renaming and moving FastADC files

  ol-imorozko

  committed
  de78c4d

  Copy full SHA for de78c4d

• Refactor providers* structures

  Show description for 8c26f9a
  ol-imorozko

  committed
  8c26f9a

  Copy full SHA for 8c26f9a

• Adjust unittests after providers refactoring

  Show description for bc1be2e
  ol-imorozko

  committed
  bc1be2e

  Copy full SHA for bc1be2e

• Extract predicate packs and correction map building to a separate class

  Show description for b87850b
  ol-imorozko

  committed
  b87850b

  Copy full SHA for b87850b

• Move cardinality mask building from Evidence set to a new structure

  Show description for 8a0d876
  ol-imorozko

  committed
  8a0d876

  Copy full SHA for 8a0d876

• Remove unused clue field from Evidence class

  ol-imorozko

  committed
  d15ae01

  Copy full SHA for d15ae01

• Remove unused N field from SearchNode class

  ol-imorozko

  committed
  1827d3d

  Copy full SHA for 1827d3d

• Optimize AccumulateClues by hashing clue with zero value

  Show description for b6a124d
  ol-imorozko

  committed
  b6a124d

  Copy full SHA for b6a124d

• Increase performance of AccumulateClues by preallocating and utilizing try_emplace

  ol-imorozko

  committed
  c9302c8

  Copy full SHA for c9302c8

• Optimize clues by moving allocations out of Build* methods

  ol-imorozko

  committed
  8ff5492

  Copy full SHA for 8ff5492

• Change predicate bitset size from 64 to 128

  ol-imorozko

  committed
  036970f

  Copy full SHA for 036970f

• Add missing cvs file for DC mining testing

  Show description for 33cddfe
  ol-imorozko

  committed
  33cddfe

  Copy full SHA for 33cddfe

• Fix clang-format header recommendtaion

  ol-imorozko

  committed
  c61f461

  Copy full SHA for c61f461

• Add DependentFalse to namespace::details

  ol-imorozko

  committed
  cc3c076

  Copy full SHA for cc3c076

• Remove inline from template functions

  ol-imorozko

  committed
  69ae4e8

  Copy full SHA for 69ae4e8

• Remove redundant static variables

  ol-imorozko

  committed
  2318ca4

  Copy full SHA for 2318ca4

• Don't define several variables on the same line

  ol-imorozko

  committed
  65d930e

  Copy full SHA for 65d930e

• Do not use std::initializer_list to store anything, replace with constexpr arrays

  ol-imorozko

  committed
  00d8041

  Copy full SHA for 00d8041

• NTreeSearch() = default Not needed

  ol-imorozko

  committed
  cec11af

  Copy full SHA for cec11af

• Rename GetInverse/MutexMap to Take since we're moving them

  ol-imorozko

  committed
  cfc5039

  Copy full SHA for cfc5039

• Capture only coverages instead of everything in labda

  ol-imorozko

  committed
  2ac5184

  Copy full SHA for 2ac5184

• To mimic Java's behavior, return 0.0 when avg1=avg2=0 in GetAverageRatio

  ol-imorozko

  committed
  221ae1b

  Copy full SHA for 221ae1b

• Do not reopen namespace std when specializing std::hash

  ol-imorozko

  committed
  80dcae1

  Copy full SHA for 80dcae1

• No need to define hash_value, declaration is enough to use boost::hash_combine

  ol-imorozko

  committed
  b75cfe7

  Copy full SHA for b75cfe7

• Use BetterEnum instead of bool to indicate tuple in ColumnOperand

  ol-imorozko

  committed
  f6c3022

  Copy full SHA for f6c3022

• Apply IWYU to src/core/algorithms/dc/FastADC

  Show description for 7aa1f06
  ol-imorozko

  committed
  7aa1f06

  Copy full SHA for 7aa1f06

• Don't use relative paths in inlcudes

  ol-imorozko

  committed
  a5c5b19

  Copy full SHA for a5c5b19

• Apply clang-format after header changes

  ol-imorozko

  committed
  fd91034

  Copy full SHA for fd91034

• Remove unnecessary assert, predicate_index_provider can't be null there anyway

  ol-imorozko

  committed
  6ed4ac7

  Copy full SHA for 6ed4ac7

• Define operator!= of DenialConstraint

  ol-imorozko

  committed
  7ec6be3

  Copy full SHA for 7ec6be3

• Move Initizlize*Map in Operator to private section and add alias for map

  ol-imorozko

  committed
  ab25724

  Copy full SHA for ab25724

• Use default == and != operators from Operator

  ol-imorozko

  committed
  2879af7

  Copy full SHA for 2879af7

• Add TODO comments for classes that are both used for DC mining and verification

  Show description for b41fdff
  ol-imorozko

  committed
  b41fdff

  Copy full SHA for b41fdff

• Use emplace back where needed

  ol-imorozko

  committed
  a562274

  Copy full SHA for a562274

Commits on Jan 14, 2025

• Make PliShard fields private

  ol-imorozko

  committed
  c424a3f

  Copy full SHA for c424a3f

• Do not explicitly delete PredicateSet constructor

  ol-imorozko

  committed
  9d8d389

  Copy full SHA for 9d8d389

• Make GetIndex in IndexProvider accept references

  ol-imorozko

  committed
  8ce8fab

  Copy full SHA for 8ce8fab

• Add inline to operator& and &= in aei.h to avoid violating ODR

  ol-imorozko

  committed
  c02e8ab

  Copy full SHA for c02e8ab

• Don't capture all variables by references in aei.h

  ol-imorozko

  committed
  f98e9e1

  Copy full SHA for f98e9e1

• Remove shared_ptrs in aei.h and simplify Hit method

  ol-imorozko

  committed
  36dfea9

  Copy full SHA for 36dfea9

• Get rid of try-catch in clue builder by adding a helper function to check first

  ol-imorozko

  committed
  d0c362d

  Copy full SHA for d0c362d

• Split variable definitions into several lines

  ol-imorozko

  committed
  26bfbd6

  Copy full SHA for 26bfbd6

• Add missing braces around if-else

  ol-imorozko

  committed
  0244e4d

  Copy full SHA for 0244e4d

• Move BuildClueSet implementation to cpp file

  ol-imorozko

  committed
  2ba381e

  Copy full SHA for 2ba381e

• Make CompareBitsets a static method of DenialConstraintSet

  ol-imorozko

  committed
  12b2881

  Copy full SHA for 12b2881

• Implement FastADC algorithm as a class derived from Algorithm

  ol-imorozko

  committed
  11aedfe

  Copy full SHA for 11aedfe

• Add FastADC python bindings

  ol-imorozko

  committed
  88a7b1f

  Copy full SHA for 88a7b1f

• Correct clang-format issues

  ol-imorozko

  committed
  cdd22ed

  Copy full SHA for cdd22ed

• Bring back missing tmp_dc.cvs and rename it appropriately

  ol-imorozko

  committed
  5e9835e

  Copy full SHA for 5e9835e

• Add example of ADC mining

  ol-imorozko

  committed
  9f2a1d5

  Copy full SHA for 9f2a1d5