Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a animated css button #120

Merged
merged 4 commits into from
Oct 23, 2022

Conversation

gauravsharmatheofficial
Copy link
Contributor

Note

  • We strictly follow the Contribution Guideline and expect contributors to follow it as well.
  • If a lot of conflicts/changes are requested in the PR, please open a new PR with the requested changes (either you or we can close the PR).

Have you read the Contribution Guidelines? If not, check CONTRIBUTING.md file first.

Yes

Description

Added a animated CSS button

Class Naming Convention for your button

  • Does your html button element have class-name like this: your_github_username-button-index (example: rajkumar-justcoder-button-1 ).

Checklist

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.

mark [X] to make it checked.

Related Issues

Fixes Issue #114

Screenshot

image

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for css-buttons-hover ready!

Name Link
🔨 Latest commit 3963e8c
🔍 Latest deploy log https://app.netlify.com/sites/css-buttons-hover/deploys/63523907eda7ed00083271f5
😎 Deploy Preview https://deploy-preview-120--css-buttons-hover.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Rajkumar-justcoder
Copy link
Member

hey your button is nice but some problem is there
ig u have not readed contribution guide so pls re read it
image
also dont format css cause we are using 4 tab index space not 7 :)
also remove this border class
image

@gauravsharmatheofficial
Copy link
Contributor Author

ok

@Rajkumar-justcoder
Copy link
Member

I guess u didn't readed contribution guide

@Rajkumar-justcoder
Copy link
Member

Go there and see demo code and see how i have given class names

@Rajkumar-justcoder
Copy link
Member

  • if u know css then if class name or tag is repeat again with diff property then it overwrite
    So u know what should be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants