-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Rust 1.67.0 and latest Mumble APIs #1
base: master
Are you sure you want to change the base?
Conversation
Please 🙏 Would love to see this updated. |
@Andicraft, for now you can pull from my fork if you'd like to start working. I don't have any plans to continue contributing to the PR at this time, and I haven't heard anything from @Dessix. I'm new to Rust, so I'd welcome any contributions to this PR. |
My apologies for the delay- It seems that submission of a draft PR doesn't actually trigger a notification to maintainers. @citelao as I've evidently fallen behind on this, I'd gladly offer maintainer permissions on the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unchecked
unwraps seem to kill the point of the Option
change- I'd prefer they be at least standard unwraps unless the performance benefit is significant, and these FFI calls shouldn't be running in a very tight loop as it stands, so the impact should be negligible. Beyond that, this looks fine.
Today, this crate does not compile. This change updates the crate to compile on modern Rust, plus adds some missing APIs and updates the README for clarity.
What changed?
How tested?
TODO
Appendix
Rust version info (via
rustup show
):