Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1462: Show characterizations on Screenings tab #844

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Oct 4, 2024

JIRA ticket: LIMS-1462

Summary:

Currently the screening tab only shows data collections with a non-zero overlap or the experiment type of 'Screening'. We should include the experiment type 'Characterisation'.

Changes:

  • If the "Screenings" tab is selected, show data collections of type "Characterization" as well
  • If the "Full Collections" tab is selected,, hide data collections of type "Characterization" as well
  • If the "Auto Integrated" tab is selected, data collections of type "Screening" and "Characterization" as well (have checked with I19)
  • If the "Phasing" tab is selected, data collections of type "Screening" and "Characterization" as well

To test:

  • Go to an MX data collection of type "Characterization" (eg /dc/visit/au34221-7/id/15375847), check it still displays if you select "Screenings", but hides if you select "Full Collections", "Auto Integrated" or "Phasing"
  • Go to an I19 data collection of type "Screening" (eg /dc/visit/cm37266-4/id/14949228), check it still displays if you select "Screenings", but hides if you select "Full Collections", "Auto Integrated" or "Phasing"
  • Go to an MX style screening data collection (eg /dc/visit/cm37236-4/id/15059304), check it still displays if you select "Screenings", but hides if you select "Full Collections", "Auto Integrated" or "Phasing"
  • Go to an MX style full data collection with fast_ep results (eg /dc/visit/cm37236-4/id/15412522), check it hides if you select "Screenings", but still displays if you select "Full Collections", "Auto Integrated" or "Phasing"
  • Go to an I19 style full data collection with xia2 results (eg /dc/visit/cm37266-4/id/15148840), check it hides if you select "Screenings", but still displays if you select "Full Collections" or "Auto Integrated"

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.1 October 22, 2024 08:39
@ndg63276 ndg63276 merged commit 8b2fd68 into pre-release/2024-R5.1 Oct 22, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1462/show-characterizations-on-screenings-tab branch October 22, 2024 08:42
ndg63276 added a commit that referenced this pull request Nov 12, 2024
* LIMS-139: link multiplex results to sample or sample group (#816)

* LIMS-1454: Show non-automatic downstream processing (#837)

* LIMS-1462: Show characterizations on Screenings tab (#844)

* LIMS-1467: Allow lab contacts to have spaces in their names (#843)

* LIMS-1489: Update message when trying to queue containers in uploaded shipments (#847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants