Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1558: Add functionality for SMILES code for any sample #880

Merged
merged 1 commit into from
Jan 28, 2025
Merged

LIMS-1558: Add functionality for SMILES code for any sample #880

merged 1 commit into from
Jan 28, 2025

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1558

Summary:

#793 allowed SMILES codes to be added to samples in plates. This PR is to add that functionality to any sample.

Changes:

  • Add SMILES entry box to sample view page

To test:

  • Go to a visit, click on the sample associated with a data collection to go to eg /samples/sid/5461086
  • Check the SMILES code box appears.
  • Edit the SMILES code, using weird symbols eg .:%=#$@+-/, check it remains after a refresh
  • Try symbols that are not allowed, eg £, check it is refused by the GUI

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R1.2 January 28, 2025 09:48
@ndg63276 ndg63276 merged commit 3366ee9 into pre-release/2025-R1.2 Jan 28, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1558/add-smiles-code-to-any-sample branch January 28, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
Ready to Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @gfrn