5 seconds for system tests

.github/scripts/check_test_durations.py

@@ -1,19 +1,28 @@
 import json
 import sys
 
-THRESHOLD = 1.0  # seconds
+# Get report filename and threshold from command-line arguments
+REPORT_FILE = sys.argv[1] if len(sys.argv) > 1 else "report.json"
+THRESHOLD = float(sys.argv[2]) if len(sys.argv) > 2 else 1.0
 
-with open("report.json") as f:
-    data = json.load(f)
+try:
+    with open(REPORT_FILE) as f:
+        data = json.load(f)
+except FileNotFoundError:
+    print(f"❌ Error: Report file '{REPORT_FILE}' not found.")
+    sys.exit(1)
+except json.JSONDecodeError:
+    print(f"❌ Error: Failed to parse JSON in '{REPORT_FILE}'.")
+    sys.exit(1)
 
 slow_tests = [
     (t["nodeid"], t["call"]["duration"])
-    for t in data["tests"]
+    for t in data.get("tests", [])
     if "call" in t and t["call"]["duration"] > THRESHOLD
 ]
 
 if slow_tests:
-    print("❌ The following tests exceeded the 1s threshold:")
+    print(f"❌ The following tests exceeded the {THRESHOLD:.2f}s threshold:")
     for test, duration in slow_tests:
         print(f" - {test}: {duration:.2f}s")
     sys.exit(1)

.github/workflows/_test.yml

@@ -50,13 +50,19 @@ jobs:
           python-version: ${{ inputs.python-version }}
           pip-install: ".[dev]"
 
-      - name: Run tests
-        run: tox -e report
+      - name: Run unit tests
+        run: tox -e unit-report
 
-      - name: Check test durations
+      - name: Check unit test durations
         run: |
-          python .github/scripts/check_test_durations.py
+          python .github/scripts/check_test_durations.py unit-report.json 1
 
+      - name: Run system tests
+        run: tox -e system-report
+
+      - name: Check system test durations
+        run: |
+          python .github/scripts/check_test_durations.py system-report.json 5
 
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v4

pyproject.toml

@@ -157,7 +157,8 @@ commands =
     type-checking: pyright src tests {posargs}
     pre-commit: pre-commit run --all-files --show-diff-on-failure {posargs}
     docs: sphinx-{posargs:build -E} -T docs build/html
-    report: pytest -m 'not (s03 or adsim)' --cov=dodal --cov-report term --cov-report xml:cov.xml --json-report --json-report-file=report.json {posargs}
+    unit-report: pytest -m 'not (s03 or adsim)' --cov=dodal --cov-report term --cov-report xml:cov.xml --json-report --json-report-file=unit-report.json tests {posargs}
+    system-report: pytest -m 'not (s03 or adsim)' --cov=dodal --cov-report term --cov-report xml:cov.xml --json-report --json-report-file=system-report.json system_tests {posargs}
 """
 
 [tool.ruff]