Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data path to /exports/mybeamline/data for training rigs #1039

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

ZohebShaikh
Copy link
Contributor

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. Run system test on training rigs

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (dfc171c) to head (ff3fa08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   97.64%   97.67%   +0.03%     
==========================================
  Files         159      159              
  Lines        6590     6590              
==========================================
+ Hits         6435     6437       +2     
+ Misses        155      153       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZohebShaikh
Copy link
Contributor Author

ZohebShaikh commented Feb 5, 2025

This PR was created due to commit, which changes the path from /data to /exports/mybeamline/data/.

Currently, the apps are pointing to a specific branch in apps/values.yaml. This PR is in draft status and can be merged once the referenced branch is merged and a release is created.

@keithralphs This is the change I had to make when running the system test during the previous sprint.

@ZohebShaikh ZohebShaikh marked this pull request as ready for review February 6, 2025 13:51
@ZohebShaikh ZohebShaikh requested a review from a team as a code owner February 6, 2025 13:51
@ZohebShaikh ZohebShaikh merged commit f370749 into main Feb 6, 2025
19 checks passed
@ZohebShaikh ZohebShaikh deleted the change-data-path branch February 6, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants