Prevent deserialisation error when fetching data from GDA embedded visit service #956
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
commented
Dec 11, 2024
| @@ -78,7 +78,7 @@ async def _identifier_from_response( | |||
| ): | |||
| response.raise_for_status() | |||
| json = await response.json() | |||
| return DataCollectionIdentifier.model_validate_json(json) | |||
| return DataCollectionIdentifier.model_validate(json) | |||
There was a problem hiding this comment.
model_validate_json is for turning a JSON string into the object. model_validate is for turning a Python object. response.json() seems to convert the JSON string returned by the numTracker service into a dict.
DiamondJoseph
changed the title
|
Please can you fix the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During beamline testing on i22 December 10th, it was found that the current visit service impl uses the wrong method to convert the return value of the GDA numTracker
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}