Set undulator gap after XBPM is stable #726
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
=======================================
Coverage 87.00% 87.01%
=======================================
Files 101 101
Lines 6966 6969 +3
=======================================
+ Hits 6061 6064 +3
Misses 905 905
|
There was a problem hiding this comment.
Looks good!
I have a nit in the undulator device, which is that this logging message is sent regardless of whether or not the gap is moved:
LOGGER.info(f"Setting undulator gap to {energy_kev:.2f} kev").
Eg we may run set, and then find that the gap is already correct, so the above logging message is a bit misleading.
| @@ -307,6 +307,10 @@ def _move_and_rotation( | |||
| params: RotationScan, | |||
| oav_params: OAVParameters, | |||
| ): | |||
| if params.demand_energy_ev: | |||
There was a problem hiding this comment.
Could: add a brief comment to explain why we're doing this, as it probably looks like a weird thing to do without context of the issue. Something like
Verify Undulator gap is correct as it sometimes has the wrong value after a beam dump
Should address #518, where Undulator gap is incorrect following beam dump.
the Undulator device checks if we are already at the correct gap when set; therefore, this PR sets the gap after XBPM is stable (in transmission_and_xbpm_feedback_for_collection_decorator), and before collection, without checking first.