Let GDA write to ISPyB sample status #740
Conversation
…sing events, following discussion with bluesky
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 86.97% 86.98% +0.01%
==========================================
Files 101 102 +1
Lines 6933 6963 +30
==========================================
+ Hits 6030 6057 +27
- Misses 903 906 +3
|
|
I think you meant to tag #604 instead in the description? |
There was a problem hiding this comment.
I think the deposit_sample_error plan you made does correctly do what we want, however, we've also slightly changed the behaviour of the sample_handling_callback which is used in other plans (load_centre_collect). This means it will update the sample status to 'loaded' at the end of the full load_centre_collect plan.
Perhaps we could remove the _record_loaded feature of SampleHandlingCallback, and instead subclass SampleHandlingCallback, then overload activity_gated_stop to include _record_loaded + call the super activity_gated_stop. Then we'd have a callback which does the right stuff and isn't used by our UDC plans
|
|
||
|
|
||
| def create_devices() -> None: | ||
| """Create the necessary devices for the plan.""" |
There was a problem hiding this comment.
Nit: Comment is a bit generic, could say something about this plan not requiring any devices
|
Also pls can you link the gerrit change you made here? |
|
Here's the Gerrit PR |
Addresses #604
Dummy plans are provided to allow GDA to trigger error or loaded status in
blsamplestatus.