Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional system tests for zocalo results bounds checks #761

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jan 24, 2025

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (aa5f360) to head (c97bcdf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files         101      101           
  Lines        6974     6974           
=======================================
  Hits         6069     6069           
  Misses        905      905           
Components Coverage Δ
i24 SSX 72.84% <ø> (ø)
hyperion 96.55% <ø> (ø)
other 96.58% <ø> (ø)

@rtuck99 rtuck99 requested a review from DominicOram January 24, 2025 10:08
@rtuck99 rtuck99 marked this pull request as ready for review January 24, 2025 10:08
@DominicOram
Copy link
Contributor

Tried to run this but getting an error of bluesky.utils.FailedStatus: <AsyncStatus, device: undulator_dcm, task: <coroutine object UndulatorDCM.set at 0x7fcb682cf2e0>, errored: FileNotFoundError(2, 'No such file or directory')> I think @rtuck99 is looking at this as part of another issue.

@rtuck99 rtuck99 force-pushed the 759_fix_grid_bounds_check branch from b1de989 to b49e654 Compare February 4, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants