Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVA support #17

Merged
merged 4 commits into from
Jul 7, 2021
Merged

Add PVA support #17

merged 4 commits into from
Jul 7, 2021

Conversation

thomascobb
Copy link
Contributor

@thomascobb thomascobb commented Jul 6, 2021

Docs build currently failing until a production release of epicscorelibs is available and can be pulled down to DLS to updated Pipfile.lock.

Still needs some tests writing when p4p is released against the same epicscorelibs prod release

Refs https://github.com/mdavidsaver/epicscorelibs/issues/13

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #17 (36e5d39) into master (94d2e66) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   82.05%   82.03%   -0.03%     
==========================================
  Files          13       13              
  Lines         797      796       -1     
==========================================
- Hits          654      653       -1     
  Misses        143      143              
Impacted Files Coverage Δ
softioc/imports.py 94.00% <ø> (-0.24%) ⬇️
softioc/softioc.py 89.24% <ø> (ø)
softioc/__init__.py 91.66% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d2e66...36e5d39. Read the comment docs.

@thomascobb thomascobb marked this pull request as ready for review July 7, 2021 19:28
@thomascobb thomascobb merged commit 379e715 into master Jul 7, 2021
@thomascobb thomascobb deleted the pva branch July 7, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants