-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes required for integration into tickit simulation framework #28
Conversation
5e7d48d
to
9012b28
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 85.83% 85.81% -0.02%
==========================================
Files 13 13
Lines 812 818 +6
==========================================
+ Hits 697 702 +5
- Misses 115 116 +1
Continue to review full report at Codecov.
|
9012b28
to
df90f39
Compare
996cfb8
to
8b868eb
Compare
@Araneidae Mac builds (apart from python 2.7) seem to be stuck in a queue somewhere on Github Actions, but I think they will work fine, so this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realise I have no idea what this patch is doing, certainly no idea what "tickit" is... Not sure I can contribute very much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've commented on the lines I'd like reviewed
4069b59
to
8158b5d
Compare
511cd12
to
b2cbcff
Compare
Make sure we use epicscorelibs libca in cothread
Move this as early as we can to avoid loading 2 versions of libca by mistake
Allow AsyncioDispatcher to take existing event loop
Need this if we want to embed IOC in existing asyncio app
Add ability to add arbitrary lines to Db file and test
Need this so we can read arbitrary db file, remove DTYP lines, add pythonSoftIOC records for logic of those records, then have it appear in the db file that is loaded in the IOC
See tests/sim_asyncio_ioc_override.py for an example of this