Add MIME type field to artifact struct #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is the right call, otherwise we'd need to download the object to our service just to provide this field |
yousefmoazzam
force-pushed
the
graph-proxy-artifact-access
branch
from
1977352 to
a52c7ea
Compare
garryod
added
enhancement
yousefmoazzam
force-pushed
the
graph-proxy-artifact-access
branch
3 times, most recently
from
dbbaebe to
db95515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses mime_guess to do a dumb guess of the MIME type based purely on the file extension.
infer has more stars on github, but I think it's being smarter and reading the file/bytes to determine the MIME type.
I didn't know if we wanted to bother to check the file data, so I chose the simpler option - feel free to suggest otherwise.