Fix SOAP 1.1 fault serialization #1110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2025 08:31
Add test that throws a MessageFault with Actor property specified (fails with "Server returned an invalid SOAP Fault")
Write faultactor after faultstring (otherwise the SOAP Fault message is invalid)
astrada
force-pushed
the
message-fault-with-actor
branch
from
402e613 to
37740be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SOAP Fault element (in SOAP 1.1) requires that
faultactoris inserted afterfaultstring, otherwise the SOAP message is invalid (https://schemas.xmlsoap.org/soap/envelope/).This patch:
faultactorsubelement afterfaultstringActorproperty of theMessageFaultcontained in the catchedFaultExceptionis correctly populated.