Skip to content

Commit

Permalink
fix: invalid tag creation
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelHillcox committed May 25, 2023
1 parent 5d0ee97 commit 7f7921a
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 11 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

## Fixed

- Rare null pointer expection when mimiced blocks load slowly
- The whitelist and blacklist tags not working due to incorrect registration
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
buildscript {
repositories {
maven { url = 'https://maven.minecraftforge.net' }
maven { url = 'https://maven.creeperhost.net' }
mavenCentral()
}
dependencies {
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ minecraft_version=1.16.5
forge_version=36.2.39
mcp_mappings=20210309-1.16.5
# Mod specific
version=3.8.3
version=3.8.4
jei_version=1.16.5:7.7.1.126
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
package com.direwolf20.buildinggadgets.common.items;


import com.direwolf20.buildinggadgets.client.renders.BaseRenderer;
import com.direwolf20.buildinggadgets.common.BuildingGadgets;
import com.direwolf20.buildinggadgets.common.tainted.building.view.BuildContext;
import com.direwolf20.buildinggadgets.common.capability.CapabilityProviderEnergy;
import com.direwolf20.buildinggadgets.common.capability.IPrivateEnergy;
import com.direwolf20.buildinggadgets.common.capability.provider.MultiCapabilityProvider;
import com.direwolf20.buildinggadgets.common.commands.ForceUnloadedCommand;
import com.direwolf20.buildinggadgets.common.tainted.concurrent.UndoScheduler;
import com.direwolf20.buildinggadgets.common.config.Config;
import com.direwolf20.buildinggadgets.common.items.modes.*;
import com.direwolf20.buildinggadgets.common.tainted.building.view.BuildContext;
import com.direwolf20.buildinggadgets.common.tainted.concurrent.UndoScheduler;
import com.direwolf20.buildinggadgets.common.tainted.inventory.IItemIndex;
import com.direwolf20.buildinggadgets.common.tainted.inventory.InventoryHelper;
import com.direwolf20.buildinggadgets.common.items.modes.*;
import com.direwolf20.buildinggadgets.client.renders.BaseRenderer;
import com.direwolf20.buildinggadgets.common.tainted.save.SaveManager;
import com.direwolf20.buildinggadgets.common.tainted.save.Undo;
import com.direwolf20.buildinggadgets.common.tainted.save.UndoWorldSave;
Expand Down Expand Up @@ -44,6 +44,7 @@
import net.minecraft.world.World;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;
import net.minecraftforge.common.Tags;
import net.minecraftforge.common.capabilities.ICapabilityProvider;
import net.minecraftforge.common.util.LazyOptional;
import net.minecraftforge.energy.CapabilityEnergy;
Expand All @@ -52,6 +53,7 @@
import org.apache.commons.lang3.tuple.Pair;

import javax.annotation.Nullable;
import java.util.HashSet;
import java.util.List;
import java.util.Optional;
import java.util.UUID;
Expand All @@ -62,16 +64,16 @@

public abstract class AbstractGadget extends Item {
private BaseRenderer renderer;
private final ITag.INamedTag<Block> whiteList;
private final ITag.INamedTag<Block> blackList;
private final Tags.IOptionalNamedTag<Block> whiteList;
private final Tags.IOptionalNamedTag<Block> blackList;
private Supplier<UndoWorldSave> saveSupplier;

public AbstractGadget(Properties builder, IntSupplier undoLengthSupplier, String undoName, ResourceLocation whiteListTag, ResourceLocation blackListTag) {
super(builder.setNoRepair());

renderer = DistExecutor.runForDist(this::createRenderFactory, () -> () -> null);
this.whiteList = BlockTags.makeWrapperTag(whiteListTag.toString());
this.blackList = BlockTags.makeWrapperTag(blackListTag.toString());
this.whiteList = BlockTags.createOptional(whiteListTag, new HashSet<>());
this.blackList = BlockTags.createOptional(blackListTag, new HashSet<>());
saveSupplier = SaveManager.INSTANCE.registerUndoSave(w -> SaveManager.getUndoSave(w, undoLengthSupplier, undoName));
}

Expand Down

0 comments on commit 7f7921a

Please sign in to comment.